malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision.
REVISION SUMMARY Since Qt5Script is deprecated and virtually useless without bindings support I got rid of it. I moved the lyrics functionality to LyricsManager but the rest I deleted without reimplementing it in C++. REPOSITORY R181 Amarok BRANCH master REVISION DETAIL https://phabricator.kde.org/D11862 AFFECTED FILES CMakeLists.txt cmake/modules/bindingstest/QtScriptBindingsTest.cpp src/ActionClasses.cpp src/App.cpp src/App.h src/CMakeLists.txt src/MainWindow.cpp src/browsers/CollectionTreeView.cpp src/browsers/servicebrowser/ServiceBrowser.cpp src/browsers/servicebrowser/ServiceBrowser.h src/configdialog/ConfigDialog.cpp src/configdialog/dialogs/ScriptSelector.cpp src/configdialog/dialogs/ScriptSelector.h src/configdialog/dialogs/ScriptsConfig.cpp src/configdialog/dialogs/ScriptsConfig.h src/configdialog/dialogs/ScriptsConfig.ui src/context/LyricsManager.cpp src/context/LyricsManager.h src/context/applets/lyrics/plugin/LyricsEngine.cpp src/context/applets/lyrics/plugin/LyricsEngine.h src/dialogs/DiagnosticDialog.cpp src/dialogs/deviceconfiguredialog.cpp src/dynamic/BiasFactory.cpp src/lyrics/LyricsManager.cpp src/lyrics/LyricsManager.h src/playlistmanager/PlaylistManager.h src/scripting/scriptconsole/CompletionModel.cpp src/scripting/scriptconsole/CompletionModel.h src/scripting/scriptconsole/ScriptConsole.cpp src/scripting/scriptconsole/ScriptConsole.h src/scripting/scriptconsole/ScriptConsoleItem.cpp src/scripting/scriptconsole/ScriptConsoleItem.h src/scripting/scriptconsole/ScriptEditorDocument.cpp src/scripting/scriptconsole/ScriptEditorDocument.h src/scripting/scriptengine/AmarokBookmarkScript.cpp src/scripting/scriptengine/AmarokBookmarkScript.h src/scripting/scriptengine/AmarokCollectionScript.cpp src/scripting/scriptengine/AmarokCollectionScript.h src/scripting/scriptengine/AmarokCollectionViewScript.cpp src/scripting/scriptengine/AmarokCollectionViewScript.h src/scripting/scriptengine/AmarokEngineScript.cpp src/scripting/scriptengine/AmarokEngineScript.h src/scripting/scriptengine/AmarokEqualizerScript.cpp src/scripting/scriptengine/AmarokEqualizerScript.h src/scripting/scriptengine/AmarokInfoScript.cpp src/scripting/scriptengine/AmarokInfoScript.h src/scripting/scriptengine/AmarokKNotifyScript.cpp src/scripting/scriptengine/AmarokKNotifyScript.h src/scripting/scriptengine/AmarokLyricsScript.cpp src/scripting/scriptengine/AmarokLyricsScript.h src/scripting/scriptengine/AmarokNetworkScript.cpp src/scripting/scriptengine/AmarokNetworkScript.h src/scripting/scriptengine/AmarokOSDScript.cpp src/scripting/scriptengine/AmarokOSDScript.h src/scripting/scriptengine/AmarokPlaylistManagerScript.cpp src/scripting/scriptengine/AmarokPlaylistManagerScript.h src/scripting/scriptengine/AmarokPlaylistScript.cpp src/scripting/scriptengine/AmarokPlaylistScript.h src/scripting/scriptengine/AmarokScript.cpp src/scripting/scriptengine/AmarokScript.h src/scripting/scriptengine/AmarokScriptConfig.cpp src/scripting/scriptengine/AmarokScriptConfig.h src/scripting/scriptengine/AmarokScriptXml.cpp src/scripting/scriptengine/AmarokScriptXml.h src/scripting/scriptengine/AmarokScriptableServiceScript.cpp src/scripting/scriptengine/AmarokScriptableServiceScript.h src/scripting/scriptengine/AmarokServicePluginManagerScript.cpp src/scripting/scriptengine/AmarokServicePluginManagerScript.h src/scripting/scriptengine/AmarokStatusbarScript.cpp src/scripting/scriptengine/AmarokStatusbarScript.h src/scripting/scriptengine/AmarokStreamItemScript.cpp src/scripting/scriptengine/AmarokStreamItemScript.h src/scripting/scriptengine/AmarokWindowScript.cpp src/scripting/scriptengine/AmarokWindowScript.h src/scripting/scriptengine/PHAACG2.py src/scripting/scriptengine/ScriptImporter.cpp src/scripting/scriptengine/ScriptImporter.h src/scripting/scriptengine/ScriptingDefines.cpp src/scripting/scriptengine/ScriptingDefines.h src/scripting/scriptengine/exporters/CollectionTypeExporter.cpp src/scripting/scriptengine/exporters/CollectionTypeExporter.h src/scripting/scriptengine/exporters/MetaTypeExporter.cpp src/scripting/scriptengine/exporters/MetaTypeExporter.h src/scripting/scriptengine/exporters/PlaylistExporter.cpp src/scripting/scriptengine/exporters/PlaylistExporter.h src/scripting/scriptengine/exporters/PlaylistProviderExporter.cpp src/scripting/scriptengine/exporters/PlaylistProviderExporter.h src/scripting/scriptengine/exporters/QueryMakerExporter.cpp src/scripting/scriptengine/exporters/QueryMakerExporter.h src/scripting/scriptengine/exporters/ScriptableBiasExporter.cpp src/scripting/scriptengine/exporters/ScriptableBiasExporter.h src/scripting/scriptmanager/ScriptItem.cpp src/scripting/scriptmanager/ScriptItem.h src/scripting/scriptmanager/ScriptManager.cpp src/scripting/scriptmanager/ScriptManager.h src/scripting/scriptmanager/ScriptUpdater.cpp src/scripting/scriptmanager/ScriptUpdater.h src/scripting/scripts/CMakeLists.txt src/scripting/scripts/ScriptWriting-HOWTO src/scripting/scripts/librivox_service/CMakeLists.txt src/scripting/scripts/librivox_service/COPYING src/scripting/scripts/librivox_service/LibrivoxEmblem.png src/scripting/scripts/librivox_service/LibrivoxIcon.png src/scripting/scripts/librivox_service/LibrivoxLogo.png src/scripting/scripts/librivox_service/LibrivoxScalableEmblem.svgz src/scripting/scripts/librivox_service/LibrivoxService.html src/scripting/scripts/librivox_service/README src/scripting/scripts/librivox_service/audio_book.svgz src/scripting/scripts/librivox_service/audio_book128.png src/scripting/scripts/librivox_service/audio_book16.png src/scripting/scripts/librivox_service/audio_book22.png src/scripting/scripts/librivox_service/audio_book32.png src/scripting/scripts/librivox_service/audio_book48.png src/scripting/scripts/librivox_service/audio_book64.png src/scripting/scripts/librivox_service/main.js src/scripting/scripts/librivox_service/script.desktop src/scripting/scripts/lyrics_lyricwiki/CMakeLists.txt src/scripting/scripts/lyrics_lyricwiki/main.js src/scripting/scripts/lyrics_lyricwiki/script.desktop src/scripting/scripts/qtscript_debug/CMakeLists.txt src/scripting/scripts/qtscript_debug/debug/debug.js src/scripting/scripts/qtscript_debug/main.js src/scripting/scripts/qtscript_debug/script.spec src/scripting/scripts/radio_station_service/CMakeLists.txt src/scripting/scripts/radio_station_service/main.js src/scripting/scripts/radio_station_service/script.desktop src/scripting/scripts/script_console/CMakeLists.txt src/scripting/scripts/script_console/main.js src/scripting/scripts/script_console/script.desktop src/scripting/scripts/templates/CMakeLists.txt src/scripting/scripts/templates/script.spec src/scripting/scripts/templates/template.js src/scripting/scripts/webcontrol/CMakeLists.txt src/scripting/scripts/webcontrol/main.js src/scripting/scripts/webcontrol/script.spec src/services/scriptable/ScriptableService.cpp src/services/scriptable/ScriptableService.h src/services/scriptable/ScriptableServiceCollection.cpp src/services/scriptable/ScriptableServiceCollection.h src/services/scriptable/ScriptableServiceCollectionTreeModel.cpp src/services/scriptable/ScriptableServiceCollectionTreeModel.h src/services/scriptable/ScriptableServiceInfoParser.cpp src/services/scriptable/ScriptableServiceInfoParser.h src/services/scriptable/ScriptableServiceManager.cpp src/services/scriptable/ScriptableServiceManager.h src/services/scriptable/ScriptableServiceMeta.cpp src/services/scriptable/ScriptableServiceMeta.h src/services/scriptable/ScriptableServiceMeta_p.h src/services/scriptable/ScriptableServiceQueryMaker.cpp src/services/scriptable/ScriptableServiceQueryMaker.h src/services/scriptable/shoutcast_service.rb To: malteveerman, #amarok Cc: #amarok, jackyalcine, nhuisman, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis, asturmlechner, schweingruber, heikobecker