[
https://issues.apache.org/jira/browse/AMBARI-2367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13682294#comment-13682294
]
Yusaku Sako commented on AMBARI-2367:
-------------------------------------
Thanks [~croberts].
1. Coding Convention: HCFSOnly and configToRemove are missing "var" in front.
This means these params are declared in the global scope, which we do not want
to do. Also, HCFSOnly is a variable name so it should begin with a lowercase
letter.
2. Ember.js has a function called "filter". It is more suited and efficient
for filtering objects out of an array.
[http://emberjs.com/api/classes/Ember.Enumerable.html#method_filter]
For example, something like the following should work (have not tested):
{code}
var coreSiteObj = coreSiteObj.filter(function(_config) {
return _config.get('name').indexOf("fs.glusterfs") < 0;
});
{code}
Basically the above would filter out all configs whose name begins with
fs.glusterfs.
3. Though not explicitly written in this JIRA, I have noticed that we need to
filter out global configs whose name starts with "fs_glusterfs" as well. Can
you do this, too?
4. "There's a global named "fs_default_name". Can we rename this to
"fs_glusterfs_default_name", as Ambari won't use this if HDFS is chosen? I
think it would create less confusion.
> HCFS properties in core-site are being set to null.
> ---------------------------------------------------
>
> Key: AMBARI-2367
> URL: https://issues.apache.org/jira/browse/AMBARI-2367
> Project: Ambari
> Issue Type: Bug
> Components: client
> Affects Versions: 1.2.5
> Reporter: Jaimin D Jetly
> Assignee: Chad Roberts
> Fix For: 1.2.5
>
> Attachments: AMBARI-2367.patch, core-site_version1.png
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
