Am 26.04.2017 um 22:15 schrieb Felix Kuehling:
On 17-04-25 02:28 AM, Michel Dänzer wrote:
On 22/04/17 02:05 AM, Felix Kuehling wrote:
__setup doesn't work in modules.
Right. We could build something like
drivers/video/fbdev/core/fb_cmdline.c:video_setup() into the kernel to
handle this, but it's a bit ugly, which is one reason why I was leaning
towards:
s8250_options is only compiled if the driver is not a module.
That doesn't prevent us from using __module_param_call directly, does it?
Although, that still doesn't work as I envision if only one driver's
option is set e.g. in /etc/modprobe.d/*.conf .
So, I'm starting to think we need a shared module for this, which
provides one or multiple module parameters to choose which driver to use
for CIK/SI[0], and provides the result to the amdgpu/radeon drivers.
That might make things easier for amdgpu-pro / other standalone amdgpu
versions in the long run as well, as they could add files to
/etc/modprobe.d/ choosing themselves by default, without having to
blacklist radeon.
What do you guys think?
Hi Michel,
You said in an earlier email that it doesn't have to be convenient. With
that in mind, I went back to a minimalistic solution that doesn't need
any additional Kconfig options and only uses two module parameters (one
in radeon, one in amdgpu).
I'm attaching my WIP patches for reference (currently based on
amd-kfd-staging). For an official review I'd rebase them on
amd-staging-4.9, remove the #if-0-ed hack that didn't work out, and add
the same for SI.
Can everyone can agree that this is good enough?
It's certainly good enough for me.
With the disabled dummy code removed feel free to stick a Reviewed-by:
Christian König <christian.koe...@amd.com> at those patches.
Regards,
Christian.
Regards,
Felix
[0] or possibly even more fine-grained in the future
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
