Re: [PATCH v2 05/10] drm/amd/amdgpu: remove unnecessary flush when enable gart

Tue, 28 May 2024 23:43:54 -0700 

Am 28.05.24 um 19:23 schrieb Yunxiang Li:

From: Likun Gao <likun....@amd.com>

Remove hdp flush for gc v11/12 when enable gart.
Remove flush tlb for gc v10/11/12 when enable gart.
Maybe add something like "That is done for each GART mapping when it is created.". 



Signed-off-by: Likun Gao <likun....@amd.com>
Signed-off-by: Yunxiang Li <yunxiang...@amd.com>
With the commit message improved the patch is Reviewed-by: Christian König <christian.koe...@amd.com>. 

Regards,
Christian.


---
  drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 3 ---
  drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c | 3 ---
  drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 3 ---
  drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c | 3 ---
  drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c | 4 ----
  5 files changed, 16 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c 
b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
index aba0a51be960..5740f94e3e44 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
@@ -4395,13 +4395,10 @@ static int gfx_v11_0_gfxhub_enable(struct amdgpu_device 
*adev)
        if (r)
                return r;
- adev->hdp.funcs->flush_hdp(adev, NULL); 
-
        value = (amdgpu_vm_fault_stop == AMDGPU_VM_FAULT_STOP_ALWAYS) ?
                false : true;
adev->gfxhub.funcs->set_fault_enable_default(adev, value); 
-       amdgpu_gmc_flush_gpu_tlb(adev, 0, AMDGPU_GFXHUB(0), 0);
return 0; 
  }
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c 
b/drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c
index 1ef9de41d193..5048b6eef9da 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c
@@ -3207,13 +3207,10 @@ static int gfx_v12_0_gfxhub_enable(struct amdgpu_device 
*adev)
        if (r)
                return r;
- adev->hdp.funcs->flush_hdp(adev, NULL); 
-
        value = (amdgpu_vm_fault_stop == AMDGPU_VM_FAULT_STOP_ALWAYS) ?
                false : true;
adev->gfxhub.funcs->set_fault_enable_default(adev, value); 
-       amdgpu_gmc_flush_gpu_tlb(adev, 0, AMDGPU_GFXHUB(0), 0);
return 0; 
  }
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c 
b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
index d933e19e0cf5..3e0ebe25a80f 100644
--- a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
@@ -974,9 +974,6 @@ static int gmc_v10_0_gart_enable(struct amdgpu_device *adev)
        if (!adev->in_s0ix)
                adev->gfxhub.funcs->set_fault_enable_default(adev, value);
        adev->mmhub.funcs->set_fault_enable_default(adev, value);
-       gmc_v10_0_flush_gpu_tlb(adev, 0, AMDGPU_MMHUB0(0), 0);
-       if (!adev->in_s0ix)
-               gmc_v10_0_flush_gpu_tlb(adev, 0, AMDGPU_GFXHUB(0), 0);
DRM_INFO("PCIE GART of %uM enabled (table at 0x%016llX).\n", 
                 (unsigned int)(adev->gmc.gart_size >> 20),
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c 
b/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c
index 527dc917e049..cadbe55f0c8f 100644
--- a/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c
@@ -891,9 +891,6 @@ static int gmc_v11_0_gart_enable(struct amdgpu_device *adev)
        if (r)
                return r;
- /* Flush HDP after it is initialized */ 
-       adev->hdp.funcs->flush_hdp(adev, NULL);
-
        value = (amdgpu_vm_fault_stop == AMDGPU_VM_FAULT_STOP_ALWAYS) ?
                false : true;
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c 
index e2c6ec3cc4f3..a677aca69a06 100644
--- a/drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c
@@ -861,14 +861,10 @@ static int gmc_v12_0_gart_enable(struct amdgpu_device 
*adev)
        if (r)
                return r;
- /* Flush HDP after it is initialized */ 
-       adev->hdp.funcs->flush_hdp(adev, NULL);
-
        value = (amdgpu_vm_fault_stop == AMDGPU_VM_FAULT_STOP_ALWAYS) ?
                false : true;
adev->mmhub.funcs->set_fault_enable_default(adev, value); 
-       gmc_v12_0_flush_gpu_tlb(adev, 0, AMDGPU_MMHUB0(0), 0);
dev_info(adev->dev, "PCIE GART of %uM enabled (table at 0x%016llX).\n", 
                 (unsigned)(adev->gmc.gart_size >> 20),

Reply via email to