[Public]

Regards,
      Prike

> -----Original Message-----
> From: Chen, Xiaogang <xiaogang.c...@amd.com>
> Sent: Thursday, September 11, 2025 6:01 AM
> To: Liang, Prike <prike.li...@amd.com>; amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander <alexander.deuc...@amd.com>; Kuehling, Felix
> <felix.kuehl...@amd.com>
> Subject: Re: [PATCH] drm/amdkfd: pass the PD BOs directly for PA
>
>
> On 9/9/2025 8:45 PM, Liang, Prike wrote:
> > [Public]
> >
> > Ping..
> >
> > Regards,
> >        Prike
> >
> >> -----Original Message-----
> >> From: Liang, Prike <prike.li...@amd.com>
> >> Sent: Monday, September 8, 2025 10:40 AM
> >> To: amd-gfx@lists.freedesktop.org
> >> Cc: Deucher, Alexander <alexander.deuc...@amd.com>; Kuehling, Felix
> >> <felix.kuehl...@amd.com>; Liang, Prike <prike.li...@amd.com>
> >> Subject: [PATCH] drm/amdkfd: pass the PD BOs directly for PA
> >>
> >> Since the PD BOs are assigned at initialization, the placement stage
> >> can obtain the PD physical address
> >> (PA) directly from the PD BOs without additional lookups.
> >>
> >> Signed-off-by: Prike Liang <prike.li...@amd.com>
> >> ---
> >>   drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> >> b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> >> index 260165bbe373..fd9cbbebbdf4 100644
> >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> >> @@ -476,7 +476,7 @@ static int vm_validate_pt_pd_bos(struct amdgpu_vm
> *vm,
> >>                return ret;
> >>        }
> >>
> >> -     vm->pd_phys_addr = amdgpu_gmc_pd_addr(vm->root.bo);
> >> +     vm->pd_phys_addr = amdgpu_gmc_pd_addr(pd);
>
> Does it fix bug or is just cosmetic change? pd and vm->root.bo should be same.
It's a refine change for the input to get the PD physical address.

> Regards
>
> Xiaogang
>
>
> >>
> >>        return 0;
> >>   }
> >> --
> >> 2.34.1

Reply via email to