[
http://jira.amdatu.org/jira/browse/AMDATU-169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angelo van der Sijpt reopened AMDATU-169:
-----------------------------------------
Assignee: Ivo Ladage - van Doorn (was: Angelo van der Sijpt)
There are a few things I don't understand,
- in GadgetManagementServiceImpl, you seem to rely on the fact that a gadget ID
consists of a string, having the format "<number>-<url>". I can't really
understand why this is.
- there is an m_startId that generates new numbers, used in the string above. I
don't understand why we use those, but regardless, it seems to me that this
will go wrong when (a) the bundle is restarted, starting again at nr 1, or (b)
two requests get reasonable close together, potentially resulting in both of
them generating the same number.
- in
http://subversion.amdatu.org/viewvc/trunk/amdatu-opensocial/gadgetmanagement/src/main/java/org/amdatu/opensocial/gadgetmanagement/service/GadgetManagementServiceImpl.java?pathrev=424&view=diff&r1=424&r2=423&diff_format=h&root=amdatu
, line 541-2-3, you put the URL in a number of locations in the gadget JSON
object. Is this what you intended?
> Separate REST calls to retrieve gadgets from AppData from dashboard plugin
> --------------------------------------------------------------------------
>
> Key: AMDATU-169
> URL: http://jira.amdatu.org/jira/browse/AMDATU-169
> Project: Amdatu
> Issue Type: Improvement
> Affects Versions: 0.0.5
> Reporter: Ivo Ladage - van Doorn
> Assignee: Ivo Ladage - van Doorn
> Fix For: 0.0.6
>
>
> In Amdatu the dashboard jquery plugin has been modified to allow
> retrieving/setting gadgets in users AppData. These calls should be moved to a
> separate file such that the plugin can be updated individually.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
