[
http://jira.amdatu.org/jira/browse/AMDATU-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=10403#comment-10403
]
Ivo Ladage - van Doorn commented on AMDATU-177:
-----------------------------------------------
- There seems to be a mix of using/not using generics. In FSGroup for example,
m_members is using generics but the constructor takes a raw type Dictionary.
Same for other classes in this implementation. I would like to see
parameterized types, or annotated with suppressWarnings if there is a good
reason to use unsafe types
- In FSUserAdminStorageProvider m_logService is defined but never used. I would
like to see some debug statements.
- In FSUserAdminStorageProvider a String hashcode is used as if it is always a
unique identifier. Why not use the entity id?
- In FSUserAdminStorageProvider role.USER should be Role.USER, same for other
static variables
- There is still a 'FIXME ugly construct' in FSUserAdminStorageProvider
- I notice many code duplication between FSUserAdmin and FSTenantStorage
bundles. Couldn't that be moved to a shared bundle? Especially when more fs
providers will be implemented in the future this might be useful.
- Why is the physical file that persisted the role stored in FSRole?
(m_internalRoleFile).
- Why is the method 'removeTenantId' in FSRoleNameList named this way? Is this
a copy-paste error?
- I notice that in this implementation each access to useradmin ends up in at
least 1 disk access, but most of the times more then 1. When authorization
checks are added all over the code, we need some caching mechanism I think.
> Implement filebased storage for pax useradmin
> ---------------------------------------------
>
> Key: AMDATU-177
> URL: http://jira.amdatu.org/jira/browse/AMDATU-177
> Project: Amdatu
> Issue Type: New Feature
> Components: Amdatu Core
> Reporter: Bram de Kruijff
> Assignee: Ivo Ladage - van Doorn
> Fix For: 0.0.6
>
>
> Create a bundle (useradminstore-fs) that implements and publishes a filebased
> storage provider for the PAX Useradmin StorageProvider SPI (@see AMDATU-130).
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
