[
http://jira.amdatu.org/jira/browse/AMDATU-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=10405#comment-10405
]
Bram de Kruijff commented on AMDATU-176:
----------------------------------------
> - In FSTenantStorageProvider m_logService is defined but not used. I would
> like to see some debug statements added.
Added 3 logmessages for lifecycle events. Not sure if more is desirable as all
API methods throw exceptions when needed.
> In FSTenantStorageProvider some minor coding violations; instance variables
> m_LogService, m_DataDirectory..
My eclipse does this by default. Can I change that? Fixed by hand.
> In FSTenantStorageProvider you are using a String hashcode as unique
> identifier, but a String hashcode is not guaranteed unique. Why are you not
> using the tenant id itself?
There is a FSTenantStore per hashcode, but each store can contain multiple
tenants. Eg. we could switch to hashcode%100 to distribute all tenants over 100
stores if this proves more efficient. Furthermore I could not find any
constraint on the tenantid other then that it is a String and I could not think
of a simple translation strategy that would make these strings filesystem safe
without introducing new possible collisions.
> Implement filebased storage for tenant management
> -------------------------------------------------
>
> Key: AMDATU-176
> URL: http://jira.amdatu.org/jira/browse/AMDATU-176
> Project: Amdatu
> Issue Type: New Feature
> Components: Amdatu Core - Tenant
> Affects Versions: 0.0.5
> Reporter: Bram de Kruijff
> Assignee: Bram de Kruijff
> Fix For: 0.0.6
>
>
> Create a bundle (tenantstore-fs) that implements and publishes a filebased
> storage provider for the TenantStorageProvider SPI (@see AMDATU-130).
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
