[
http://jira.amdatu.org/jira/browse/AMDATU-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12092#comment-12092
]
Marcel Offermans commented on AMDATU-495:
-----------------------------------------
More review issues:
* We named the package adapTOR and the class adapTER. We should decide on one
of the two. A bit of googling shows adapTER is more used, but as long as we're
consistent I don't care which one we use.
* The updated() method has a few issues:
** it does not check validity of the incoming parameters (throwing
ConfigurationException if something is missing);
** it is unable to update a tenant once it is configured (which it should
support);
** our tenant now has an ID, but it also gets a PID and I guess it makes sense
to align the two;
** I'm not sure why we're special casing "hostname" here, and not copying any
other configured properties. I would stick any extra properties in the Tenant
and not special case anything. Hostname is only needed when you use the
hostname based resolver filter. But that is not the only resolver. In fact we
made that pluggable. I would not even exclude the option to resolve a tenant in
a way that is completely different (for connections coming in through some
other means than HTTP).
** In MultiTenantBundleActivator there is a log() method which looks up the log
service by hand. Why not use the dependency manager to inject it instead? Now
it contains a small bug. Any service method can throw an exception, in which
case the code never reaches the ungetService call.
> Do a full code review and create refactor proposals
> ---------------------------------------------------
>
> Key: AMDATU-495
> URL: http://jira.amdatu.org/jira/browse/AMDATU-495
> Project: Amdatu
> Issue Type: Sub-task
> Reporter: Bram de Kruijff
> Fix For: Sprint 1
>
>
> Do a full code review and create refactor proposals
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
http://jira.amdatu.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
Amdatu-developers mailing list
[email protected]
http://lists.amdatu.org/mailman/listinfo/amdatu-developers
