[
http://jira.amdatu.org/jira/browse/AMDATU-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12097#comment-12097
]
Jan Willem Janssen commented on AMDATU-495:
-------------------------------------------
Some additional review issues:
* TenantAwareBundleContext uses some asserts in its constructor; the two
asserts regarding identifier are "interesting", so to say. I don't know whether
we want to rely on asserts for this, so we might need to convert those to real
exceptions;
* TenantAwareBundleContext still has lots of TODOs/FIXMEs which seem relevant
to fix before delivering Amdatu 0.0.3;
* TenantAdapter has hardcoded references to LogService (not that bad, API is
extremely stable) and JaxRsSpi (bad! is our own code, may be subject to change);
* TenantAdapter & MultiTenantBundleActivator use quite some stuff from the
bundle headers, but the "(String) m_context.getBundle().getHeaders().get(...)"
is rather tedious to read, please create a private method for this to aid
readability;
* MultiTenantBundleActivator#init is hard to read & understand, while its flow
is (should) be rather easy:
*# determine scope (still up for discussion);
*# create platform instance of service, if needed;
*# create tenant instance(s) of service, if needed.
* MultiTenantBundleInputStream has a possible leak of resources when
IOExceptions occur during the adaption of the JarInputStream for MT;
* MultiTenantBundleInputStream creates a ByteArrayOutputStream that has an
initial size of 32 bytes(!) which grows exponentially if needed. This might
cause lots of temporary arrays to be created on the heap and thus cause
performance penalties.
> Do a full code review and create refactor proposals
> ---------------------------------------------------
>
> Key: AMDATU-495
> URL: http://jira.amdatu.org/jira/browse/AMDATU-495
> Project: Amdatu
> Issue Type: Sub-task
> Reporter: Bram de Kruijff
> Fix For: Sprint 1
>
>
> Do a full code review and create refactor proposals
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
http://jira.amdatu.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
Amdatu-developers mailing list
[email protected]
http://lists.amdatu.org/mailman/listinfo/amdatu-developers
