[ 
http://jira.amdatu.org/jira/browse/AMDATU-556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607#comment-12607
 ] 

Marcel Offermans commented on AMDATU-556:
-----------------------------------------

I see what you mean, but if you have a global bundle that publishes services 
that interact with other services, which is the case for ManagedService and 
ConfigurationAdmin which are clearly part of the same API, then in general you 
have a situation that cannot work. Either both the configuration admin bundle 
and all bundles that use it are global, or they're all local. Mixing them does 
not work.

This "fix" simply hides all global services, except for two specific ones which 
from a user's point of view are arbitrarily chosen. To me that's not a solution 
to the problem. In your example, you should simply not deploy a global bundle 
that uses configuration admin, *or* at least make sure that not every tentant 
actually has configuration for it (I'm assuming the problem was that this 
ManagedService got configuration data from multiple sources and that was the 
problem).


                
> Remove reference to web in TenantAdapter
> ----------------------------------------
>
>                 Key: AMDATU-556
>                 URL: http://jira.amdatu.org/jira/browse/AMDATU-556
>             Project: Amdatu
>          Issue Type: Sub-task
>          Components: Amdatu Core
>            Reporter: Marcel Offermans
>             Fix For: Sprint 4
>
>
> TenantAdapter has the following method:
> {code}
>     protected String getTenantFilter() {
>         return "(|(objectClass=org.amdatu.web.rest.jaxrs.JaxRsSpi)"
>             + "(objectClass=org.osgi.service.log.LogService)("
>             + PID_KEY + "=" + getTenantPID() + "))";
>     }
> {code}
> I don't understand why a tenant filter must contain a hardcoded reference to 
> some amdatu web service. If we need a mechanism to work around a bug, then at 
> least we should generalize the fix to be broader than just JAX-RS. Quite 
> frankly, I still hope we find a better solution.
> Second thing: Why does it make a specific exception for LogService? This 
> states that you never want to make LogService tenant specific, which is a 
> choice we should not make for our users.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
http://jira.amdatu.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
_______________________________________________
Amdatu-developers mailing list
[email protected]
http://lists.amdatu.org/mailman/listinfo/amdatu-developers

Reply via email to