[
http://jira.amdatu.org/jira/browse/AMDATU-556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Willem Janssen resolved AMDATU-556.
---------------------------------------
Assignee: Bram de Kruijff (was: Jan Willem Janssen)
Resolution: Fixed
Rewrote the filter to no longer depend on specific services, but rely on
service-properties only.
The only thing I faced during the implementation of this fix is that we should
either annotate all global services, or have a kind of fallback scenario for
unmodified global services. For now, the fallback scenario is implemented, but
may have to be changed to make it configurable in the near future.
> Remove reference to web in TenantAdapter
> ----------------------------------------
>
> Key: AMDATU-556
> URL: http://jira.amdatu.org/jira/browse/AMDATU-556
> Project: Amdatu
> Issue Type: Sub-task
> Components: Amdatu Core
> Reporter: Marcel Offermans
> Assignee: Bram de Kruijff
> Fix For: Sprint 4
>
>
> TenantAdapter has the following method:
> {code}
> protected String getTenantFilter() {
> return "(|(objectClass=org.amdatu.web.rest.jaxrs.JaxRsSpi)"
> + "(objectClass=org.osgi.service.log.LogService)("
> + PID_KEY + "=" + getTenantPID() + "))";
> }
> {code}
> I don't understand why a tenant filter must contain a hardcoded reference to
> some amdatu web service. If we need a mechanism to work around a bug, then at
> least we should generalize the fix to be broader than just JAX-RS. Quite
> frankly, I still hope we find a better solution.
> Second thing: Why does it make a specific exception for LogService? This
> states that you never want to make LogService tenant specific, which is a
> choice we should not make for our users.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
http://jira.amdatu.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
Amdatu-developers mailing list
[email protected]
http://lists.amdatu.org/mailman/listinfo/amdatu-developers
