Brian, I agree on your two points ;-)
-----Original Message----- From: Brian E Carpenter <[email protected]> Date: Tuesday, 1 December 2020 at 20:28 To: Eric Vyncke <[email protected]>, The IESG <[email protected]> Cc: "[email protected]" <[email protected]>, "[email protected]" <[email protected]>, "[email protected]" <[email protected]>, Sheng Jiang <[email protected]> Subject: Re: Éric Vyncke's No Objection on draft-ietf-anima-grasp-api-08: (with COMMENT) On 02-Dec-20 03:16, Éric Vyncke via Datatracker wrote: ... > Please find below one some non-blocking COMMENT points, and one nits. I have > also request IoT directorate and INT directorate reviews, so, you may expect > more reviews. Some of the reviews requested at Last Call never showed up, which is mildly annoying if they're going to show up late. All your comments are easy to fix, assuming "new ID needed". Thanks Brian > > I hope that this helps to improve the document, > > Regards, > > -éric > > == COMMENTS == > > -- Section 1 -- > In figure 1, is the "GRASP API Library" identical to the "basic GRASP library" > mentioned later in the text? > > -- Section 2.1 -- > May I assume that the bulleted list is not exhaustive? Probably worth stating > "For example, ..." if this is the case. > > -- Section 2.2.1 -- > This whole section looks more like a tutorial than something useful in an IETF > document ;-) but no problem to leave it. Same applies for section 2.2.2 and > even to 2.2.3. > > -- Section 2.3.2.2 -- > Should it be specified that the timeout is an *unsigned* integer? Same applies > for "loop_count" in section 2.3.2.3 > > -- Section 2.3 -- > Several occurrences of "returned parameters"... should it better be "returned > values" ? > > -- Section 2.3.3 -- > "All ASAs must use this call." should it be followed by "before issuing any > other API calls" ? > > "automatically if an ASA crashes" but what about "graceful termination" ? > > == NITS == > > -- Section 1 -- > Suggestion move figure 1 earlier in the text to improve readability. > > > > _______________________________________________ Anima mailing list [email protected] https://www.ietf.org/mailman/listinfo/anima
