Hi Brian, On Thu, Jan 20, 2022 at 01:38:42PM +1300, Brian E Carpenter wrote: > Hi Ben, > ... > > > ---------------------------------------------------------------------- > > DISCUSS: > > ---------------------------------------------------------------------- > > > > It looks like the indentation in the example MAIN PROGRAM in Appendix C > > is incorrect, or at least confusing, in the "do forever" loop therein. > > Specifically, assuming semantic whitespace as in Python, we never > > actually perform grasp negotiation for the "good_peer in peers" case. > > Additionally, I think we may have a risk of getting stuck in a loop > > making no progress so long as good_peer remains in the set of discovered > > peers but does not have enough resources available for our > > request/negotiation to succeed. I think we want to clear out good_peer > > if a negotiation fails, to avoid that scenario. > > I'll have to check on that by comparing with the Python code, which > definitely doesn't have those problems. Probably a bit too much was > elided when simplifying it into pseudocode. Will fix.
That makes sense. [lots of other stuff snipped] I have no other replies, and the datatracker will let me know when the revised I-D is posted, so I can take a look. Thanks! -Ben _______________________________________________ Anima mailing list [email protected] https://www.ietf.org/mailman/listinfo/anima
