Hi, This has been committed. Thanks, Rob.
Adam > -----Original Message----- > From: Magesh Umasankar [mailto:[EMAIL PROTECTED] > Sent: Monday, 4 February 2002 8:38 AM > To: Ant Developers List > Subject: Re: [SUBMIT] Refactor & combination of mail tasks > > > Erik/Steve: > > Will one of you please take care of this? > > http://marc.theaimsgroup.com/?t=100802277000004&r=1&w=2 > > Cheers, > Magesh > > ----- Original Message ----- > From: "Rob Oxspring" <[EMAIL PROTECTED]> > To: <[EMAIL PROTECTED]> > Sent: Monday, December 10, 2001 5:18 PM > Subject: [SUBMIT] Refactor & combination of mail tasks > > > > Hi all, > > > > A while back (possibly when MimeMail was submitted) it was > suggested that > > the mail tasks should be integrated into one, using some reflection to > > attempt to use JavaMail. Recently I had a desire to send some binary > > attachments but didn't want to have to install JavaMail on > every developer > > workstation and so UU encoding was hit upon. > > > > The upshot of all this was that I've integrated the three > encoding formats > > into a single task using JavaMail if available or uu encoding (via > > sun.misc.UUEncoder - presumably available to any sun based JDK?). > > > > It should be possible to drop in the new task where the old one was used > and > > not notice the difference. > > > > <project name="emailtest" default="main"> > > <target name="main"> > > <mail message="My message" > > subject="Ant Submission Test"> > > > > <from name="From Rob" address="[EMAIL PROTECTED]"/> > > <to name="To Rob" address="[EMAIL PROTECTED]"/> > > <fileset dir="."> > > <include name="*.xml"/> > > </fileset> > > </mail> > > </target> > > </project> > > > > Magesh: your includefilenames patch caught me mid flow so I've tried to > > patch it in but would appreciate it if you would have a quick check that > > things are coming out OK. Only the PlainMailer is affected by this > > attribute since I didn't know how best to add it into the other formats. > > > > Todo: Probably could find / implement uu encoding but Sun's solution was > > handy and did the trick for now. > > > > Now if things run true to form I'll be back in touch in five > minutes as I > > spot some daft mistake but in the meantime if others could > eyeball it too > it > > would be appreciated. > > > > Hope its deemed good enough... > > > > Rob > > > > > -- > To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> > For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
