On Wed, 02 Oct 2013 16:35:31 +0200, Marc Lehmann <[email protected]>
wrote:
On Wed, Oct 02, 2013 at 09:55:46AM +0200, Christian Walde
<[email protected]> wrote:
If cpantesters infrastructure uses a broken DNS setup
In any case, it's pretty easy to break perl modules willingly in a lot of
ways. If you already know that your environment is misconfigured, then
you can simply skip the tests yourself.
As it is, the test diagnoses actual problems that people have. There is
no need to make the test ineffective for artificially created problems
that a single user has created.
I never said that the entire cpantesters infrastructure has broken DNS, i
said that i tried to explain what the cpantesters infrastructure expects
a FAIL to mean in the ideal case and what the average user expects testing
results to mean. As long as AnyEvent supplies a fail in this case, users
will suspect it and not know that their system is broken.
Also do note that this is not the case of a single user. You have a number
of reports on this in your cpantesters matrix:
http://matrix.cpantesters.org/?dist=AnyEvent+7.05
Can you explain how this actually detects a broken dns service? It seems
you are simply skipping the test on failure, which is the same as not
having it in the first place.
It forcibly disables all hosts overrides by ensuring that ENV does not
declare any host overrides and that any overrides in /etc/hosts are
ignored. Then it tries to resolve a broken hostname and expects no results
on a healthy system. If there are no results it tests the override as
intended, and if the system is broken it notes that and continues.
If you don't like that, and would prefer the test cancel out loudly, this
snippet will do the necessary work and make the test skip like your others
do, and only if the system is broken as made clear by the ability to
resolve a non-existant host.
my ($err, @result) = getaddrinfo $test_host;
if (@result or !$err) {
print qq{1..0 # DNS returns bogus results\n};
exit 0;
}
(It will of course necessitate delaying the Test::More plan.)
--
With regards,
Christian Walde
_______________________________________________
anyevent mailing list
[email protected]
http://lists.schmorp.de/mailman/listinfo/anyevent
