On Wed, Oct 02, 2013 at 06:46:04PM +0200, Christian Walde <[email protected]> wrote: > >What are these failures you talk about, and what's your evidence that > >these are indeed due to opendns (or a similar service), and not due to > >some other bug? > > Going through http://matrix.cpantesters.org/?dist=AnyEvent+7.05 you have 49 > FAILs due to this, none of them by me even. Some excerpts:
My guess is that most if not all of these are due to an unrelated bug in 7.05 that has been fixed a while ago (wildcard domains), and would match these reports perfectly, unlike your theory. (Which kind of underlines the need for the test to actually report failures in such cases). > A number of those i am sure are not even under the control of the user, but > mandated by their internet service provider. An internet service provider cannot mandate this at all. > https://metacpan.org/source/MLEHMANN/AnyEvent-7.05/t/81_hosts.t > > has exactly two tests, both of them check that the result of a failed > resolve were overwritten by the instructions given in file indicated by > the environment variable PERL_ANYEVENT_HOSTS. Ok, that's a weird use of the word "overwritten", but that is essentially correct. > >All that your patch does is to effectively disable the whole test, which > >means it cannot even fulfill the purpose that, according to you, the > >average user expects it to have. > > All my patch does is skip the test if it is conclusively shown that the > system cannot adequately communicate a failed resolve. On all other systems > it will work as before and FAIL if PERL_ANYEVENT_HOSTS is ignored. I really can't see how it would do so, but it's hard to guess from the excerpt you gave me. Still, it ignores the test when it would rightfully fail, and doesn't actually improve anything, while hiding real issues. -- The choice of a Deliantra, the free code+content MORPG -----==- _GNU_ http://www.deliantra.net ----==-- _ generation ---==---(_)__ __ ____ __ Marc Lehmann --==---/ / _ \/ // /\ \/ / [email protected] -=====/_/_//_/\_,_/ /_/\_\ _______________________________________________ anyevent mailing list [email protected] http://lists.schmorp.de/mailman/listinfo/anyevent
