Jeff, I don't have a problem with it being in, but it actually needs to do something we can measure. There are significant overall differences between 4.0.10 and 4.5, although if you look at small parts it seems the same. Just as an example, the patch in driver.c was hundreds of lines off from 4.0.10 to 4.5.
Somehow Gustaf has been able to reproduce the fix with just the driver.c change, and the new fix he is trying out also works. I'm not sure we understand why either of them work quite yet, or if they will continue to work...and that is the real problem. Magical fixes are nice, but in the long we might need to know more about it. I have ab run without either fix and never had a problem. Actually the call was in driver.c, but the function body was a noop, it never even registered the TriggerDriver, the AtReadyProcs fuction was completely removed, not even defined. To me this only means that I don't know how to reproduce the bad behavior, but at least it didn't cause any difference for me. tom jackson On Friday 19 October 2007 11:11, Jeff Rogers wrote: > I'm thinking the call to NsRunAtReadyProcs should be re-added in. It > was apparently removed a long time ago, just after 4.0.10 was released: > > http://aolserver.cvs.sourceforge.net/aolserver/aolserver/nsd/queue.c?r1=1.2 >4&r2=1.25 > > As the api was not being used at all it was fine to remove it, until it > became useful for this race condition :) I haven't successfully > reproduced the problem in 4.5 yet (or read the code deeply, but the main > connection service loop - queue.c:NsConnThread - is not significantly > different now) so it may be a different underlying problem than the one > I described, but it should be an easy test to see if adding the AtReady > callbacks back into the end of the loop helps things. > > -J > > > But, you're absolutely right: we need to figure this out, one way or > > another. Thanks for finding this. > > > > -- Dossy > > -- > AOLserver - http://www.aolserver.com/ > > To Remove yourself from this list, simply send an email to > <[EMAIL PROTECTED]> with the body of "SIGNOFF AOLSERVER" in the > email message. You can leave the Subject: field of your email blank. -- AOLserver - http://www.aolserver.com/ To Remove yourself from this list, simply send an email to <[EMAIL PROTECTED]> with the body of "SIGNOFF AOLSERVER" in the email message. You can leave the Subject: field of your email blank.
