Dossy Shiobara wrote:
On 2007.10.13, Tom Jackson <[EMAIL PROTECTED]> wrote:
This all looks great, except for the fact that the NsRunAtReadyProcs
proc is never called.
In 4.5, that appears to be the case. In 4.0, it's called from
nsd/queue.c.
I'd need to look more closely at the code to see if we should remove
those functions entirely in 4.5 or if there's actually a missing call to
NsRunAtReadyProcs() somewhere.
I'm thinking the call to NsRunAtReadyProcs should be re-added in. It
was apparently removed a long time ago, just after 4.0.10 was released:
http://aolserver.cvs.sourceforge.net/aolserver/aolserver/nsd/queue.c?r1=1.24&r2=1.25
As the api was not being used at all it was fine to remove it, until it
became useful for this race condition :) I haven't successfully
reproduced the problem in 4.5 yet (or read the code deeply, but the main
connection service loop - queue.c:NsConnThread - is not significantly
different now) so it may be a different underlying problem than the one
I described, but it should be an easy test to see if adding the AtReady
callbacks back into the end of the loop helps things.
-J
But, you're absolutely right: we need to figure this out, one way or
another. Thanks for finding this.
-- Dossy
--
AOLserver - http://www.aolserver.com/
To Remove yourself from this list, simply send an email to <[EMAIL PROTECTED]>
with the
body of "SIGNOFF AOLSERVER" in the email message. You can leave the Subject:
field of your email blank.
