I think the best way to do this is to fork the project, then replace it with his code, then commit his diff, and then do a pull request to Dossy.
That preserves the history, and allows us to see what Majid's changes are. Jade *Jade Rubick* | Director of Development | TRUiST 2201 Wisconsin Ave NW, Suite 250 | Washington, DC 20007 | www.truist.com | +1 202 903 2564 P Please consider the environment before printing The information contained in this email/document is confidential and may be legally privileged. Access to this email/document by anyone other than the intended recipient(s) is unauthorized. If you are not an intended recipient, any disclosure, copying, distribution, or any action taken or omitted to be taken in reliance to it, is prohibited. On Fri, Sep 3, 2010 at 3:24 PM, Sep Ng <thejackschm...@gmail.com> wrote: > Majid, > > I will be more than happy to do it. I just probably need to figure > how and where to git pull. I don't think I have an account however. > > Regards. > > On Sep 4, 5:03 am, Majid Khan <majidkha...@gmail.com> wrote: > > Yes just remove what's there because there are multiple/redundant copies > of > > the same file so its very confusing which file is the correct version of > > memcache and about the history, ever since I have imported no one added > any > > patch so there is nothing that we will lose. The code I have sent you is > the > > improved bug free version of nsmemcache which I have never commit to CVS > (my > > bad) nor its documented. > > > > Sep I would want you to please do your test against the one which Dossy > will > > commit. Dossy I haven't prepared any test case, I shall prepare the one > and > > will let you know. > > > > Regards, > > > > Majid. > > > > > > > > On Fri, Sep 3, 2010 at 7:11 PM, Dossy Shiobara <do...@panoptic.com> > wrote: > > > Is it necessary to remove what's there (and lose the change history) or > > > just commit your changes? Send me what you have and I can commit it, or > you > > > can fork and send a pull request through GitHub. > > > > > Are your changes documented? How can they be tested? Will they conflict > > > with Sep's BUFSIZE patch? > > > > > "Majid Khan" <majidkha...@gmail.com> wrote: > > > > > >Hi Dossy, > > > > > >Is it possible to remove the one which you just added on github > because > > > it's > > > >not the clean version which I wanted to add at the time when I ported > for > > > >aolserver and also I have fixed a type casting bug in the code later > on. > > > So > > > >I wanted to import a clean and a stable version of nsmemcache to > github. I > > > >am not sure whether I would be able to import to github but if you > want I > > > >can give you a tar ball of nsmecache and you can import that one. > > > > > -- > > > Dossy Shiobara > > > > > -- > > > AOLserver -http://www.aolserver.com/ > > > > > To Remove yourself from this list, simply send an email to < > > > lists...@listserv.aol.com> with the > > > body of "SIGNOFF AOLSERVER" in the email message. You can leave the > > > Subject: field of your email blank. > > > > -- > > AOLserver -http://www.aolserver.com/ > > > > To Remove yourself from this list, simply send an email to < > lists...@listserv.aol.com> with the > > body of "SIGNOFF AOLSERVER" in the email message. You can leave the > Subject: field of your email blank. > > > -- > AOLserver - http://www.aolserver.com/ > > To Remove yourself from this list, simply send an email to < > lists...@listserv.aol.com> with the > body of "SIGNOFF AOLSERVER" in the email message. You can leave the > Subject: field of your email blank. > -- AOLserver - http://www.aolserver.com/ To Remove yourself from this list, simply send an email to <lists...@listserv.aol.com> with the body of "SIGNOFF AOLSERVER" in the email message. You can leave the Subject: field of your email blank.
