stas        2002/12/02 06:20:23

  Modified:    xs/Apache/Module Apache__Module.h
               .        Changes
  Log:
  Resolve a segfault in Apache::Module::get_config() for the edge case
  when the package name is bogus. XSub can't return Svnull, should be
  &PL_sv_undef
  
  Revision  Changes    Path
  1.7       +5 -5      modperl-2.0/xs/Apache/Module/Apache__Module.h
  
  Index: Apache__Module.h
  ===================================================================
  RCS file: /home/cvs/modperl-2.0/xs/Apache/Module/Apache__Module.h,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- Apache__Module.h  28 Aug 2002 03:16:20 -0000      1.6
  +++ Apache__Module.h  2 Dec 2002 14:20:23 -0000       1.7
  @@ -6,7 +6,7 @@
       char nameptr[256];
       char *base;
       module *modp;
  -
  +    
       /* Does the module name have a '.' in it ? */
       if ((base = ap_strchr(name, '.'))) {
           int len = base - name;
  @@ -64,19 +64,19 @@
       }
   
       if (!(modp = apr_hash_get(scfg->modules, name, APR_HASH_KEY_STRING))) {
  -        return Nullsv;
  +        return &PL_sv_undef;
       }
   
       if (!(ptr = ap_get_module_config(v, modp))) {
  -        return Nullsv;
  +        return &PL_sv_undef;
       }
   
       if (!(table = modperl_module_config_table_get(aTHX_ FALSE))) {
  -        return Nullsv;
  +        return &PL_sv_undef;
       }
   
       if (!(obj = modperl_svptr_table_fetch(aTHX_ table, ptr))) {
  -        return Nullsv;
  +        return &PL_sv_undef;
       }
   
       return SvREFCNT_inc(obj);
  
  
  
  1.68      +3 -0      modperl-2.0/Changes
  
  Index: Changes
  ===================================================================
  RCS file: /home/cvs/modperl-2.0/Changes,v
  retrieving revision 1.67
  retrieving revision 1.68
  diff -u -r1.67 -r1.68
  --- Changes   29 Nov 2002 05:36:56 -0000      1.67
  +++ Changes   2 Dec 2002 14:20:23 -0000       1.68
  @@ -10,6 +10,9 @@
   
   =item 1.99_08-dev
   
  +Resolve a segfault in Apache::Module::get_config() for the edge case
  +when the package name is bogus. [Stas Bekman]
  +
   Apache::Reload: add support for watching and reloading modules only in
   specified sub-dirs [Harry Danilevsky <[EMAIL PROTECTED]>]
   
  
  
  


Reply via email to