Suresh Krishnan has entered the following ballot position for draft-ietf-aqm-pie-07: No Objection
When responding, please keep the subject line intact and reply to all email addresses included in the To and CC lines. (Feel free to cut this introductory paragraph, however.) Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html for more information about IESG DISCUSS and COMMENT positions. The document, along with other ballot positions, can be found here: https://datatracker.ietf.org/doc/draft-ietf-aqm-pie/ ---------------------------------------------------------------------- COMMENT: ---------------------------------------------------------------------- Section 4.1: QDELAY_REF is used here without definition. Suggest something like: s/is smaller than half of QDELAY_REF/is smaller than half of the target delay value (QDELAY_REF)/ Section 4.2: Not sure what this piece of pseudo-code intends to achieve. Isn't this a no-op? } else { p = p; } Section 5.3: What does the following text intend to say? Do you mean when it is turned off? "When PIE is optionally turned on and off, ..." Section 5.4: The forced drop at 8.5/PIE->drop_prob_ packets is not consistent with the pseudo-code in page 24. The drop_early() does not the drop packets if the queue is not congested. Either the pseudo-code or text in this section needs to be adjusted. _______________________________________________ aqm mailing list aqm@ietf.org https://www.ietf.org/mailman/listinfo/aqm