> > > >---------------------------------------------------------------------- >COMMENT: >---------------------------------------------------------------------- > >Section 4.1: >QDELAY_REF is used here without definition. Suggest something like: > >s/is smaller than half of QDELAY_REF/is smaller than half of the >target delay value (QDELAY_REF)/
Done. > >Section 4.2: > >Not sure what this piece of pseudo-code intends to achieve. Isn't this a >no-op? > > } else { > p = p; > } It is a no-op. At least this covers all the cases, less chance to make mistakes :-). > >Section 5.3: > >What does the following text intend to say? Do you mean when it is turned >off? > >"When PIE is optionally turned on and off, ..." How about ³PIE can automatically turn on and off"? > >Section 5.4: > >The forced drop at 8.5/PIE->drop_prob_ packets is not consistent >with the pseudo-code in page 24. The drop_early() does not the >drop packets if the queue is not congested. Either the >pseudo-code or text in this section needs to be adjusted. > > If a queue is not congested, we don¹t drop packets. I added comments in Section 5.4 to be clear. Thanks, Rong _______________________________________________ aqm mailing list aqm@ietf.org https://www.ietf.org/mailman/listinfo/aqm