Matthew Howkins wrote:
I have just committed to CVS a patch to refactor some of the display code in ArcEm:

5. Move static variables enodes and xpollenode, and #define POLLGAP from each */DispKbd.c to DispKbdShared.c

Uh...

7. Common code moved from DisplayKbd_PollHost() to DisplayKbd_Poll()
8. Common code moved from DisplayKbd_InitHost() to DisplayKbd_Init()

This reduces each */DispKbd.c by about 50 lines of duplicated code.

And screws the gp2x port quite heavily.

It doesn't even actually compile now!! :-((

The code you removed was *NOT* common as I had tweaked around
with it heavily to try and get at least some semblence of
performance out of the gp2x port.


The RISC OS port also appeas to be broken... keyboard/mouse input
doesn't work now.


I.


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
arcem-devel mailing list
arcem-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/arcem-devel

Reply via email to