Yeah, for situations like that, if it's an in-depth change to core arches, it may not be easy to make a direct pull request from your repo to the main one. Typically, I at least just try to make distinct changes in the commit history so that it's easy for anyone to see what exactly needed to be done to make the modification. It's likely that to make a PR, your best course of action would be to make a new branch in your fork from the master branch (after updating your master to match the current archesproject/arches/master branch) and then apply the changes to that new branch and make a PR in the main arches repo. Of course this can be more tricky if your changes depend on other, unrelated modifications you've made, so watch out for that.
At any rate, pull requests are always more than welcome on the main repo, and this functionality you've described would likely be very useful to others. So, if you have the time, it would be great to see! Also, making pull requests is good because it opens the door to an detailed discussion of the new code on github. Cheers, Adam On Monday, January 22, 2018 at 2:59:22 AM UTC-6, Angela Feliu wrote: > > Hello Adam, > I added a new Function to achieve the pop up with diferent cards. Now I > would like to know if your collegues have this in mind for future > improvements in arches v4. > The problem is I have to change the model/resource,py to get the new > descriptor for the new function(I also added a marker to add symbology in > the markers) so if we want to update your new features would be a problem > to merge files > > Thanks in advance > > El dimecres, 17 gener de 2018 17:17:06 UTC+1, Angela Feliu va escriure: >> >> Hello everyone, >> I would like to know if it's possible to show in the map popup info from >> different cards. >> >> For example I have a card with the name and another with imgs as they >> have to be edited in different menus. >> So the problem is when I want to add this information in the popup I can >> only add one. Is it something that will change in the future or will remain >> like this??? >> >> Thanks in advance!!! >> > -- -- To post, send email to archesproject@googlegroups.com. To unsubscribe, send email to archesproject+unsubscr...@googlegroups.com. For more information, visit https://groups.google.com/d/forum/archesproject?hl=en --- You received this message because you are subscribed to the Google Groups "Arches Project" group. To unsubscribe from this group and stop receiving emails from it, send an email to archesproject+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
