Hi Manisha,
On Mon, Jan 6, 2014 at 11:51 AM, Manisha Gayathri <mani...@wso2.com> wrote: > After the offline discussion with Dimuthu, we decided to go ahead with the > per developer repo for now. Per developer build, deploy and test will be > considered later. > So what you are suggesting is that the developer is not allowed to build the project? IMO, all of develop, build, deploy and test by a developer comes under one user story. We should at least have a user story for build and deployment for a developer, if we are only going to work with repo part now. WDYT? Thanks, Janaka > > Thanks > Manisha > > > On Mon, Jan 6, 2014 at 11:45 AM, Manisha Gayathri <mani...@wso2.com>wrote: > >> Thanks for bringing this up Janaka. Was going to address this separately. >> >> What I thought was, the ideal scenario would be, the developer should be >> able to build, deploy and test in their own isolated environment. But this >> incorporates a lot of work and changes. In that case, the user story will >> be like once the developer does the Pull Request he waits to test until the >> Pull Merge Accept Notification comes from the app owner. This is >> inconvenient from the developer's perspective. >> >> Dimuthu, how can we address this? >> >> Thanks >> Manisha >> >> >> >> On Mon, Jan 6, 2014 at 11:32 AM, Janaka Ranabahu <jan...@wso2.com> wrote: >> >>> Hi Manisha, >>> >>> >>> On Mon, Jan 6, 2014 at 11:02 AM, Manisha Gayathri <mani...@wso2.com>wrote: >>> >>>> Hi all, >>>> >>>> According to the diagram in Sanjiva's mail, I have come up with a >>>> sequence diagram of the scenarios that would cover in this user story. >>>> Please refer [1] >>>> >>>> For M11, we are hoping to implement the scenarios up to Add Developer >>>> user story. >>>> >>>> [1]. >>>> http://www.websequencediagrams.com/?lz=dGl0bGUgUGVyIERldmVsb3BlciBSZXBvIEltcGwgd2l0aCBHaXRIdWIKCm9wdCBDcmVhdGUgTmV3IFRlbmFudAogAAIHQWRtaW4gLT4AKAc6ACMIYSBHaXQgb3JnYW5pemF0aW9uACESQUYAJgluAD8bQUY6IFByb3ZpZGUgZwBGDyBjb250ZXh0ICYgY3JlZGVudGlhbHMAfCJuIGFwcCBvd25lciB0ZWFtAIFtBnB1c2ggcGVybWlzcwCBHRVHaXRodWI6YwCBXAhkZXYAOQZpZiBub3QgZXhpc3RpbmcgYW5kIGFkZCB1c2VyIHRvACAJCmVuZACCQhFBcHAKICBBcHBPAIELBQCCCBIAGgdGAIJVE25ldyByZXBvIGluIHRoZSBvcmcuAIINCAogAIM-BwCCaAUAWAc6IFJlc3BvbnNlAINhBgCDcQVkZXRhaQCCMwUAXwZKZW5raW5zOiBBZGQAgxcFYnVpbGQgdGFzayBmb3IAgjgFcmVwbwCBRQpBZGQAhEEKAIE_DwCEWgk6IGludml0AIM0BnRvIGpvaW4gcHJvamVjdAogAIUACwCEFgdTdXJlIACBaRFGb3JrAIFnBW1haW4AgQEGAIFdDABjC0hlcmUncyB5b3VyIGZvcmtlZAAnCACBQSYALQdkZXYAgV8PAIYrCldyaXRlcyBDb2RlAIEyEACGCghHaXQgUHVsbACBUhAAggwLACsUAIIrC0xvY2FsIElERQCDAgYASx5zaACDaw0Ag0IJQgA0BwCDVQcAgxIHIENsb3VkOiBEZXBsb3kgZACIBQkAVRUAgz8LAIguCnRlc3QvZGVidWcAhVQKUHVsbCBSZXF1ZXMAg0UVABsFcgAXCQCFVQYAhRkKABMMIHJlY2VpdmVkAIYUEACFRgt2aQCGAgUARgkAhkALAIkQCE1lcmdlAIR_Gk5vdGlmeSBhY2NlcHQAhyEF&s=vs2010 >>>> >>> >>> The given diagram only contains up to committing the changes. How are we >>> going to handle build and deployment. Can developers have their own build >>> and own isolated deployment with their own repo? Or are they only allowed >>> to test once they merge with the central repo. >>> >>> Thanks, >>> Janaka >>> >>>> >>>> Thanks >>>> Manisha >>>> >>>> >>>> On Sun, Jan 5, 2014 at 3:07 AM, Dimuthu Leelarathne >>>> <dimut...@wso2.com>wrote: >>>> >>>>> Hi Manisha and all, >>>>> >>>>> Please see my comments inline. >>>>> >>>>> >>>>>>> On Friday, January 3, 2014, Manisha Gayathri wrote: >>>>>>> >>>>>>>> Hi all, >>>>>>>> >>>>>>>> For the M11 of App Factory, we are implementing per developer repo >>>>>>>> feature to give a github like experience for the developers. The user >>>>>>>> story >>>>>>>> for this federated development will be as follows: >>>>>>>> - Once an app-owner creates an application, the application will >>>>>>>> be getting a repo in gitblit >>>>>>>> - When a developer logs in, he gets an option to fork the main >>>>>>>> repo of the app >>>>>>>> >>>>>>> >>>>> Fork option should not be something done by developer when he logs in. >>>>> Here is the user story we want from Sanjiva's mail titled "per-developer >>>>> git repos for App Factory. Here is the link from the mail [1]. The diagram >>>>> here is very precise. Basically the fork request should be sent by AF when >>>>> a developer is added to the project. And it should be done by AF on a >>>>> listener when "add user to application" event is fired, so the developer >>>>> do >>>>> not do it. >>>>> >>>>> And as per the mail states GitBlit does not support "PR(pull request) >>>>> git workflow". Then thinking along this line, IMO we should NOT implement >>>>> "per developer" repos using Gitblit, because it would require major >>>>> hacking. I believe we should integrate with GitHub for this feature. >>>>> >>>>> Basically our story should be "if underlying repo provider supports PR >>>>> workflow then we do [1]". So lets provide this feature using GitHub. And >>>>> if >>>>> one day GitBlit provides "PR git workflow", lets make it available for Git >>>>> repositories as well. >>>>> >>>>> thanks, >>>>> dimuthu >>>>> >>>>> >>>>> [1] >>>>> >>>>> http://www.websequencediagrams.com/?lz=dGl0bGUgQXBwIEZhY3RvcnkgR2l0IFJlcG9zCgpvcHQgQ3JlYXRlIE5ldyBBcHAKICBBcHBPd25lciAtPiBBRjoAGQhuABcKRiAtPiBHaXRibGl0ABMNcmVwbwogABMIADwFAEYHOiBIZXJlJ3MgeW91ciBhcHAAJAgARwZKZW5raW5zOiBBZGQAZQVidWlsZCB0YXNrIGZvACYLZW5kAIExBkFkZCBEZXZlbG9wZXIAgScPAA8JOiBpbnZpdGF0aW9uIHRvIGpvaW4gcHJvamVjdAogADYKAIFjCFN1cmUgAIFJGXJlcG8AgQkFZGV2AIFYDgBmCwCBWwxwcml2ADEIAIFCKWRldgCBXA8AgR0KV3JpdGVzIENvZGUAgS8QAIMGCUdpdCBQdWxsAIFQEACCCgsALBQAgikLTG9jYWwgSURFAIMABgBLH3NoAINkDgCDQglCADYHAINVBwCDEgcgQ2xvdWQ6IERlcGxveSBkAIJ6CQBXFQCDPwsAgyMKdGVzdC9kZWJ1ZwCEBQpQdWxsIFJlcXVlcwCDRRUAGwVyABcJAIU9BgCFEwoAEwwgcmVjZWl2ZWQAhXwQAIVCCVJldmkAhWkFAEYJAIYoCwCGDwlNZXJnZQCFABpOb3RpZnkgYWNjZXB0AIVTBQ&s=vs2010 >>>>> >>>>> >>>>> >>>>>> - The developer should not be permitted to directly commit to the >>>>>>>> main repo >>>>>>>> - Developer can fork the main repo and have it as his remote repo. >>>>>>>> Developer commits his changes to his remote repo >>>>>>>> - Once the changes are committed he sends a pull request with the >>>>>>>> committed changes >>>>>>>> - App owner can login to the main repo and check what are the >>>>>>>> available pull requests. He can review the commits and reject the >>>>>>>> problamatic ones and merge the accepted changes with the main repo >>>>>>>> >>>>>>>> There are couple of things to consider. >>>>>>>> We are using Gitblit as the repo provider in AF. In Gitblit only >>>>>>>> the fork option is available. The pull merge capability of Gitblit is >>>>>>>> still >>>>>>>> in work in progress state according to their discussions. They are >>>>>>>> hoping >>>>>>>> to make it available in the next release but still could not find even >>>>>>>> a >>>>>>>> trunk build of those components. In that case we will need to implement >>>>>>>> that capability in AF side. >>>>>>>> Therefore, we will give all these repo releated options from AF >>>>>>>> side. >>>>>>>> >>>>>>>> Thanks >>>>>>>> Manisha >>>>>>>> >>>>>>>> -- >>>>>>>> ~Regards >>>>>>>> *Manisha Eleperuma* >>>>>>>> Software Engineer >>>>>>>> WSO2, Inc.: http://wso2.com >>>>>>>> lean.enterprise.middleware >>>>>>>> >>>>>>>> *blog: http://manisha-eleperuma.blogspot.com/ >>>>>>>> <http://manisha-eleperuma.blogspot.com/>* >>>>>>>> *mobile: +94 71 8279777 <%2B94%2071%208279777>* >>>>>>>> >>>>>>>> -- >>>>>>>> You received this message because you are subscribed to the Google >>>>>>>> Groups "WSO2 Engineering Group" group. >>>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>>> send an email to engineering-group+unsubscr...@wso2.com. >>>>>>>> For more options, visit >>>>>>>> https://groups.google.com/a/wso2.com/groups/opt_out. >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> S.Uthaiyashankar >>>>>>> VP Engineering >>>>>>> WSO2 Inc. >>>>>>> http://wso2.com/ - "lean . enterprise . middleware" >>>>>>> >>>>>>> Phone: +94 714897591 >>>>>>> >>>>>>> -- >>>>>>> You received this message because you are subscribed to the Google >>>>>>> Groups "WSO2 Engineering Group" group. >>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>> send an email to engineering-group+unsubscr...@wso2.com. >>>>>>> For more options, visit >>>>>>> https://groups.google.com/a/wso2.com/groups/opt_out. >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Shiroshica Kulatilake >>>>>> >>>>>> Architect, >>>>>> WSO2, Inc. http://wso2.com/ >>>>>> Phone: +94 776523867 >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Dimuthu Leelarathne >>>>> Architect & Product Lead of App Factory >>>>> >>>>> WSO2, Inc. (http://wso2.com) >>>>> email: dimut...@wso2.com >>>>> Mobile : 0773661935 >>>>> >>>>> Lean . Enterprise . Middleware >>>>> >>>> >>>> >>>> >>>> -- >>>> ~Regards >>>> *Manisha Eleperuma* >>>> Software Engineer >>>> WSO2, Inc.: http://wso2.com >>>> lean.enterprise.middleware >>>> >>>> *blog: http://manisha-eleperuma.blogspot.com/ >>>> <http://manisha-eleperuma.blogspot.com/>* >>>> *mobile: +94 71 8279777 <%2B94%2071%208279777>* >>>> >>>> >>>> _______________________________________________ >>>> Architecture mailing list >>>> Architecture@wso2.org >>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>>> >>>> >>> >>> >>> -- >>> *Janaka Ranabahu* >>> Senior Software Engineer; WSO2 Inc.; http://wso2.com >>> >>> >>> * E-mail: jan...@wso2.com <http://wso2.com>**M: **+94 718370861 >>> <%2B94%20718370861>* >>> >>> >>> Lean . Enterprise . Middleware >>> >>> >>> _______________________________________________ >>> Architecture mailing list >>> Architecture@wso2.org >>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>> >>> >> >> >> -- >> ~Regards >> *Manisha Eleperuma* >> Software Engineer >> WSO2, Inc.: http://wso2.com >> lean.enterprise.middleware >> >> *blog: http://manisha-eleperuma.blogspot.com/ >> <http://manisha-eleperuma.blogspot.com/>* >> *mobile: +94 71 8279777 <%2B94%2071%208279777>* >> >> > > > -- > ~Regards > *Manisha Eleperuma* > Software Engineer > WSO2, Inc.: http://wso2.com > lean.enterprise.middleware > > *blog: http://manisha-eleperuma.blogspot.com/ > <http://manisha-eleperuma.blogspot.com/>* > *mobile: +94 71 8279777 <%2B94%2071%208279777>* > > > _______________________________________________ > Architecture mailing list > Architecture@wso2.org > https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture > > -- *Janaka Ranabahu* Senior Software Engineer; WSO2 Inc.; http://wso2.com * E-mail: jan...@wso2.com <http://wso2.com>**M: **+94 718370861* Lean . Enterprise . Middleware
_______________________________________________ Architecture mailing list Architecture@wso2.org https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
