I think Isuru has valid reasons to maintain it as a separate datasource file (it will help the feature to be installed without issues).
Even from a product perspective, IMO its ok to have a product specific datasource file. For example, AFAIR, BAM has a bam-datasources.xml in it. On Thu, Jul 23, 2015 at 12:31 PM, Isuru Perera <isu...@wso2.com> wrote: > Hi, > > WSO2 Carbon Metrics [1] is an independent feature and it not part of the > Carbon Kernel. I wanted to keep metrics configurations separate and > therefore when products install the Metrics Feature, the metrics components > will work without any manual changes. This fact was not discussed before > and I just wanted metrics to be a self-contained feature. > > Since the Carbon supports loading data sources from > $CARBON_HOME/repository/conf/datasources/*-datasources.xml files, I don't > see any issue with keeping the metrics datasource in a separate file. > > However, from a product's perspective, I can understand that it's good to > have datasource configurations in one file. So, for products like MB, we > can stop copying metrics-datasources.xml file from Maven assembly and > maintain metrics datasource in product's master-datasources.xml file. > > [1] https://github.com/wso2/carbon-metrics > > On Fri, Jul 17, 2015 at 8:38 PM, Subash Chaturanga <sub...@wso2.com> > wrote: > >> Hi, >> In MB 3.0 alpha pack I can see that there is a new file called >> metrics-datasources.xml. All kernel and carbon component level data >> sources are defined in masterdatasource.xml. On top of that, any valid >> reason for this to move to a separate file. If this fact already raised in >> an old conversation and made justification, can someone please link me to >> the discussion. >> > > > > -- > Isuru Perera > Associate Technical Lead | WSO2, Inc. | http://wso2.com/ > Lean . Enterprise . Middleware > > about.me/chrishantha > Contact: +IsuruPereraWSO2 <https://www.google.com/+IsuruPereraWSO2/about> > > _______________________________________________ > Architecture mailing list > Architecture@wso2.org > https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture > > -- *Amila Maharachchi* Senior Technical Lead WSO2, Inc.; http://wso2.com Blog: http://maharachchi.blogspot.com Mobile: +94719371446
_______________________________________________ Architecture mailing list Architecture@wso2.org https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
