+1. carbon.product file hasn't really been used by the products. So, +1 to make it optional.
On Fri, Jan 20, 2017 at 3:06 PM, Dilan Udara Ariyaratne <dil...@wso2.com> wrote: > Hi Folks, > > In the process of building C5, we currently require carbon.product for the > following goals. > [1] publish-product > [2] generate-runtime > > This file maintains current version of the carbon kernel to be utilized by > "carbon-feature-plugin" in the build process. > Keeping this value in carbon.product prevents the kernel from been > auto-released as it requires manual intervention to bump > version values as necessary during the release process. > > In order to solve this issue, we are currently in the process of improving > Carbon-Feature-Plugin to dynamically create this file during build time > using > a template where the necessary version value information is read from > corresponding distribution pom file. > > In order to support backward compatibility, we will still maintain the > original approach of keeping a carbon.product file somewhere appropriate > in the distribution folder and read it accordingly when > <productConfigurationFile> tag is present in the pom file. > > In the meantime, as the way to go forward, we will introduce the following. > > Carbon-Feature-Plugin will be updated to read version and other optional > values that were originally persisted in the file, from the pom itself. > After reading these values, plugin will dynamically create the > carbon.product which will then be taken into reference by underlying > eclipse.tycho plugin as in the usual way of execution. > > WDYT ? > > Thank You. > > *Dilan U. Ariyaratne* > Senior Software Engineer > WSO2 Inc. <http://wso2.com/> > Mobile: +94766405580 <%2B94766405580> > lean . enterprise . middleware > > > _______________________________________________ > Architecture mailing list > Architecture@wso2.org > https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture > > -- *Kasun Gajasinghe*Associate Technical Lead, WSO2 Inc. email: kasung AT spamfree wso2.com linked-in: http://lk.linkedin.com/in/gajasinghe blog: http://kasunbg.org phone: +1 650-745-4499, 77 678 0813
_______________________________________________ Architecture mailing list Architecture@wso2.org https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
