Hi Vithursa, What I asked is do we really need to keep tenant_id in AM_APPLICATION_ATTRIBUTES table since we already have tenancy in Application level ? I guess Application to application attribute has an one to many relationship.
Thanks Godwin On Mon, Jun 11, 2018, 6:43 AM Vithursa Mahendrarajah <vithu...@wso2.com> wrote: > Hi Godwin, > > Yes, Tenant-awareness is incorporated in this feature and tenant_id is > stored against each attribute (in AM_APPLICATION_ATTRIBUTES). > > Thanks, > > On Mon, Jun 11, 2018 at 10:54 AM, Godwin Amila Shrimal <god...@wso2.com> > wrote: > >> Hi Vithursa/Nuwan, >> >> Sorry for giving my feedback at this moment. Do we have to especially >> think of tenant awareness for the application attributes and add tennat_id >> to AM_APPLICATION_ATTRIBUTES table? Our Application is already tenant >> aware. right? Correct me if I am wrong. >> >> Thanks >> Godwin >> >> On Tue, May 1, 2018 at 7:03 AM Vithursa Mahendrarajah <vithu...@wso2.com> >> wrote: >> >>> Hi, >>> >>> +1 for making this feature tenant aware. I will accommodate it into the >>> design. >>> >>> As discussed with Nuwan, the table AM_APPLICATION_ATTRIBUTES will be >>> modified to have an additional column to store tenant_id. >>> >>> Thanks & Regards, >>> >>> >>> On Sat, Apr 28, 2018 at 6:55 PM, Nuwan Dias <nuw...@wso2.com> wrote: >>> >>>> One more thought that came to mind is that we have to make this feature >>>> tenant aware. In the sense that each tenant should be able to decide its >>>> own attributes. Let’s change the design to accommodate that. >>>> >>>> On Wed, Apr 25, 2018 at 9:07 PM Vithursa Mahendrarajah < >>>> vithu...@wso2.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> I will remove IS_REQUIRE column from AM_APPLICATION_ATTRIBUTES. We can >>>>> specify in UI as *required* by reading values from xml file. >>>>> >>>>> Thanks & Regards, >>>>> >>>>> >>>>> On Wed, Apr 25, 2018 at 1:05 PM, Nuwan Dias <nuw...@wso2.com> wrote: >>>>> >>>>>> >>>>>> >>>>>> On Wed, Apr 25, 2018 at 12:56 PM, Vithursa Mahendrarajah < >>>>>> vithu...@wso2.com> wrote: >>>>>> >>>>>>> Hi all, >>>>>>> >>>>>>> Please find updated user story in [1]. (Also .pdf is attached). >>>>>>> >>>>>>> As discussed with Nuwan, Following implementation flow is planned to >>>>>>> store custom attributes against an Application. >>>>>>> >>>>>>> 1. In the first step, user needs to configure keys of attributes in >>>>>>> api-manager.xml. Attributes may need to be differentiated as >>>>>>> *required* and *optional*. User should not be able to create an >>>>>>> Application without attributes that marked as *required*. >>>>>>> >>>>>>> For instance, if the required keys were *External Reference Id* and >>>>>>> *Billing >>>>>>> Tier *where *External Reference Id* is a mandatory key, user can >>>>>>> configure as, >>>>>>> >>>>>>> <ApplicationConfigurations> >>>>>>> <ApplicationAttributes> >>>>>>> <Attribute required = "true">External Reference >>>>>>> Id</Attribute> >>>>>>> <Attribute>Billing Tier</Attribute> >>>>>>> </ApplicationAttributes> >>>>>>> </ApplicationConfigurations> >>>>>>> >>>>>>> 2. Next, when creating Application, user can specify values via UI. >>>>>>> Mock UI looks as, >>>>>>> >>>>>>> >>>>>>> >>>>>>> 3. A new table, names as AM_APPLICATION_ATTRIBUTES is created with 4 >>>>>>> columns. Such as, >>>>>>> 1. APPLICATION_ID >>>>>>> 2. ATTRIBUTE_KEY >>>>>>> 3. ATTRIBUTE_VALUE >>>>>>> 4. IS_REQUIRED >>>>>>> Each attribute key, value pairs and boolean indicates whether it is >>>>>>> a mandatory attribute or not, will be stored along with Application Id. >>>>>>> >>>>>> >>>>>> I don't think we need to store the 'required' field in the database >>>>>> since it is mentioned in the configuration. >>>>>> >>>>>>> >>>>>>> Fetched attributes are committed into AM_APPLICATION_ATTRIBUTES. >>>>>>> Following DB schema will be added to the current API Manager database. >>>>>>> >>>>>>> >>>>>>> Feedback and suggestions are highly appreciated. >>>>>>> >>>>>>> [1] >>>>>>> https://docs.google.com/document/d/18OMI3sjHETOcKfQ5fldm4Inf4gsU1TxDrhfs2l9GfhI/edit?usp=sharing >>>>>>> >>>>>>> Thanks & Regards, >>>>>>> >>>>>>> >>>>>>> >>>>>>> On Fri, Apr 20, 2018 at 9:41 AM, Vithursa Mahendrarajah < >>>>>>> vithu...@wso2.com> wrote: >>>>>>> >>>>>>>> Hi all, >>>>>>>> @Youcef, >>>>>>>> Thanks for the use case, you have provided. We will try to >>>>>>>> incorporate it and will also share the updated user story. >>>>>>>> >>>>>>>> @Fazlan, @Ishara, >>>>>>>> +1 for your suggestions. I will update the user story and share it. >>>>>>>> >>>>>>>> @Rajith, >>>>>>>> +1 for your suggestion. We could differentiate key values as >>>>>>>> *required* and *optional *based on requirements and user can >>>>>>>> specify these according to their needs. >>>>>>>> >>>>>>>> @Nuwan, >>>>>>>> Yes, I will work on these. As first step, I will work on design and >>>>>>>> implementation of saving these data against the Application and also >>>>>>>> will >>>>>>>> update the user story accordingly. >>>>>>>> >>>>>>>> Thanks & Regards, >>>>>>>> >>>>>>>> >>>>>>>> On Thu, Apr 19, 2018 at 11:18 AM, Nuwan Dias <nuw...@wso2.com> >>>>>>>> wrote: >>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> On Thu, Apr 19, 2018 at 11:15 AM, Rajith Roshan <raji...@wso2.com> >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> Hi all >>>>>>>>>> >>>>>>>>>> On Thu, Apr 19, 2018 at 9:19 AM, Nuwan Dias <nuw...@wso2.com> >>>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>>> We don't have an application search capability right now right? >>>>>>>>>>> If so I don't think we should be adding such a feature. Because its >>>>>>>>>>> unlikely someone will have so many apps to search from. >>>>>>>>>>> >>>>>>>>>>> Some of the usages of these properties that I could think are >>>>>>>>>>> (based on some replies as well). >>>>>>>>>>> >>>>>>>>>>> 1. The need to publish these data to third party key managers >>>>>>>>>>> when generating application keys. >>>>>>>>>>> 2. The need to publish these data to application/subscription >>>>>>>>>>> related workflows. >>>>>>>>>>> 3. The need to access these data at the API Gateway when >>>>>>>>>>> processing a request (we could probably use the JWT for this). >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> So based on the usages of these attributes , and analyzing some >>>>>>>>>> of the use cases , I think better option is to have set of >>>>>>>>>> predefined key >>>>>>>>>> values for these application attributes. Giving the api consumer >>>>>>>>>> to add the both key , value pairs is meaning less because none of >>>>>>>>>> the key >>>>>>>>>> manager, gateway, workflows etc would not know how to process those >>>>>>>>>> values, >>>>>>>>>> if api consumer add what ever the values they have in mind as keys. >>>>>>>>>> I think we should have way to configure the set of predefined >>>>>>>>>> keys , where UI will read the config and render the keys as text >>>>>>>>>> fields so >>>>>>>>>> api consumer can provide values to those keys. >>>>>>>>>> With fixed set of pre configured attributes and we can also >>>>>>>>>> provide flexibility to define both key value pairs to the api >>>>>>>>>> consumer as >>>>>>>>>> well. >>>>>>>>>> >>>>>>>>> >>>>>>>>> +1. >>>>>>>>> >>>>>>>>>> >>>>>>>>>>> Anyhow, Vithursa let's take these requirements step by step. >>>>>>>>>>> First lets work on the design and implementation of saving these >>>>>>>>>>> data >>>>>>>>>>> against the Application. >>>>>>>>>>> >>>>>>>>>>> On Thu, Apr 19, 2018 at 7:12 AM, Prasanna Dangalla < >>>>>>>>>>> prasa...@wso2.com> wrote: >>>>>>>>>>> >>>>>>>>>>>> Hi Vithursa, >>>>>>>>>>>> >>>>>>>>>>>> Is there a possibilty of adding a functionality to search >>>>>>>>>>>> applications using custom attibutes. IMO this will aslo be a >>>>>>>>>>>> valied use >>>>>>>>>>>> case. >>>>>>>>>>>> >>>>>>>>>>>> Thanks >>>>>>>>>>>> Prasanna >>>>>>>>>>>> >>>>>>>>>>>> On Thu, Apr 19, 2018 at 5:35 AM Ishara Cooray <isha...@wso2.com> >>>>>>>>>>>> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> Hi Vithursa, >>>>>>>>>>>>> >>>>>>>>>>>>> IMO you also need to have *another user story to delete >>>>>>>>>>>>> applications with custom attributes *where you need to make >>>>>>>>>>>>> sure application is successfully deleted from the application >>>>>>>>>>>>> list along >>>>>>>>>>>>> with its custom attributes. >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks & Regards, >>>>>>>>>>>>> Ishara Cooray >>>>>>>>>>>>> Senior Software Engineer >>>>>>>>>>>>> Mobile : +9477 262 9512 >>>>>>>>>>>>> WSO2, Inc. | http://wso2.com/ >>>>>>>>>>>>> Lean . Enterprise . Middleware >>>>>>>>>>>>> >>>>>>>>>>>>> On Thu, Apr 19, 2018 at 1:54 AM, Nuwan Dias <nuw...@wso2.com> >>>>>>>>>>>>> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> Based on what Youcef has mentioned, we would need to include >>>>>>>>>>>>>> these additional properties on the JWT perhaps so that they can >>>>>>>>>>>>>> be accessed >>>>>>>>>>>>>> by the Gateway upon validating an access token. >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Wed, Apr 18, 2018 at 11:38 PM, Youcef HILEM < >>>>>>>>>>>>>> youcef.hi...@laposte.fr> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>>> Hi, >>>>>>>>>>>>>>> ++++ for this feature. >>>>>>>>>>>>>>> I do not have access to the document [1] but we wish to >>>>>>>>>>>>>>> develop mediations >>>>>>>>>>>>>>> reinforcing access control to APIs according to these >>>>>>>>>>>>>>> metadata (example >>>>>>>>>>>>>>> (key: client-contract, value: contractx), ie : association >>>>>>>>>>>>>>> between client-id >>>>>>>>>>>>>>> & client-contract-id). >>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>> Youcef HILEM >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>> Sent from: >>>>>>>>>>>>>>> http://wso2-oxygen-tank.10903.n7.nabble.com/WSO2-Architecture-f62919.html >>>>>>>>>>>>>>> _______________________________________________ >>>>>>>>>>>>>>> Architecture mailing list >>>>>>>>>>>>>>> Architecture@wso2.org >>>>>>>>>>>>>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> -- >>>>>>>>>>>>>> Nuwan Dias >>>>>>>>>>>>>> >>>>>>>>>>>>>> Software Architect - WSO2, Inc. http://wso2.com >>>>>>>>>>>>>> email : nuw...@wso2.com >>>>>>>>>>>>>> Phone : +94 777 775 729 >>>>>>>>>>>>>> >>>>>>>>>>>>>> _______________________________________________ >>>>>>>>>>>>>> Architecture mailing list >>>>>>>>>>>>>> Architecture@wso2.org >>>>>>>>>>>>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>> _______________________________________________ >>>>>>>>>>>>> Architecture mailing list >>>>>>>>>>>>> Architecture@wso2.org >>>>>>>>>>>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>>>>> *Prasanna Dangalla* >>>>>>>>>>>> Senior Software Engineer, WSO2, Inc.; http://wso2.com/ >>>>>>>>>>>> lean.enterprise.middleware >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> *cell: +94 718 11 27 51* >>>>>>>>>>>> *twitter: @prasa77* >>>>>>>>>>>> >>>>>>>>>>>> _______________________________________________ >>>>>>>>>>>> Architecture mailing list >>>>>>>>>>>> Architecture@wso2.org >>>>>>>>>>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> Nuwan Dias >>>>>>>>>>> >>>>>>>>>>> Software Architect - WSO2, Inc. http://wso2.com >>>>>>>>>>> email : nuw...@wso2.com >>>>>>>>>>> Phone : +94 777 775 729 >>>>>>>>>>> >>>>>>>>>>> _______________________________________________ >>>>>>>>>>> Architecture mailing list >>>>>>>>>>> Architecture@wso2.org >>>>>>>>>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Rajith Roshan >>>>>>>>>> Senior Software Engineer, WSO2 Inc. >>>>>>>>>> Mobile: +94-7 <%2B94-71-554-8430>17-064-214 >>>>>>>>>> >>>>>>>>>> _______________________________________________ >>>>>>>>>> Architecture mailing list >>>>>>>>>> Architecture@wso2.org >>>>>>>>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Nuwan Dias >>>>>>>>> >>>>>>>>> Software Architect - WSO2, Inc. http://wso2.com >>>>>>>>> email : nuw...@wso2.com >>>>>>>>> Phone : +94 777 775 729 >>>>>>>>> >>>>>>>>> _______________________________________________ >>>>>>>>> Architecture mailing list >>>>>>>>> Architecture@wso2.org >>>>>>>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Vithursa Mahendrarajah >>>>>>>> Software Engineer >>>>>>>> WSO2 Inc. - http ://wso2.com >>>>>>>> Mobile : +947*66695643* <+94%2077%20819%201300> >>>>>>>> >>>>>>>> >>>>>>>> * <http://wso2.com/signature> <http://wso2.com/signature> >>>>>>>> <http://wso2.com/signature>* >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Vithursa Mahendrarajah >>>>>>> Software Engineer >>>>>>> WSO2 Inc. - http ://wso2.com >>>>>>> Mobile : +947*66695643* <+94%2077%20819%201300> >>>>>>> >>>>>>> >>>>>>> * <http://wso2.com/signature> <http://wso2.com/signature> >>>>>>> <http://wso2.com/signature>* >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Nuwan Dias >>>>>> >>>>>> Software Architect - WSO2, Inc. http://wso2.com >>>>>> email : nuw...@wso2.com >>>>>> Phone : +94 777 775 729 >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Vithursa Mahendrarajah >>>>> Software Engineer >>>>> WSO2 Inc. - http ://wso2.com >>>>> Mobile : +947*66695643* <+94%2077%20819%201300> >>>>> >>>>> >>>>> * <http://wso2.com/signature> <http://wso2.com/signature> >>>>> <http://wso2.com/signature>* >>>>> >>>> -- >>>> Nuwan Dias >>>> >>>> Software Architect - WSO2, Inc. http://wso2.com >>>> email : nuw...@wso2.com >>>> Phone : +94 777 775 729 >>>> >>> >>> >>> >>> -- >>> Vithursa Mahendrarajah >>> Software Engineer >>> WSO2 Inc. - http ://wso2.com >>> Mobile : +947*66695643* <+94%2077%20819%201300> >>> >>> >>> * <http://wso2.com/signature> <http://wso2.com/signature> >>> <http://wso2.com/signature>* >>> _______________________________________________ >>> Architecture mailing list >>> Architecture@wso2.org >>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>> >> >> >> -- >> *Godwin Amila Shrimal* >> Associate Technical Lead >> WSO2 Inc.; http://wso2.com >> lean.enterprise.middleware >> >> mobile: *+94772264165* >> linkedin: *https://www.linkedin.com/in/godwin-amila-2ba26844/ >> <https://www.linkedin.com/in/godwin-amila-2ba26844/>* >> twitter: https://twitter.com/godwinamila >> <http://wso2.com/signature> >> >> _______________________________________________ >> Architecture mailing list >> Architecture@wso2.org >> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >> >> > > > -- > Vithursa Mahendrarajah > Software Engineer > WSO2 Inc. - http ://wso2.com > Mobile : +947*66695643* <+94%2077%20819%201300> > > > * <http://wso2.com/signature> <http://wso2.com/signature> > <http://wso2.com/signature>* >
_______________________________________________ Architecture mailing list Architecture@wso2.org https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
