>Thomas, is there a reason for this?

Yes - if you think you have to do anything manualy in the autoupdate 
procedure - you have to do it all manualy (IMHO). Let assp do what is 
right and it will be right.
How should assp know if and when you want to replace the assp.pl, there is 
no need for the script to make a backup for an untouched file.

How ever, moving one line
     return 0 if $AutoUpdateASSP == 1;
 down some statements will do it - backup the current file and syntax 
check the new version.

Thomas



Von:    Scott MacLean <[email protected]>
An:     GrayHat <[email protected]>, ASSP development mailing list 
<[email protected]>
Datum:  19.01.2011 15:16
Betreff:        Re: [Assp-test] ASSP update mechanism suggestion





At 03:22 AM 1/19/2011, GrayHat wrote:

> > ASSP is doing the update exactly this suggested way for over a year
> > now - the folder for the old (replaced) versions is also 'download' -
> > the file name of the replaced versions contains the version number.
> > The folder has to be cleaned up manualy.
>
>Maybe I'm blind :) but I've been running ASSP v2 for more than a year
>now and sincerely I *never* found such "versioned backups" sitting
>inside the download folder, it only contains assp.pl and the "tgz" file
>and I mean it contains ONLY the latest version, no backups at all...
>maybe the backup is performed only if ASSP is set to automatically
>install the updates and doesn't kick in if it's set to only download and
>notify ?

Ditto - I've never seen a versioned backup - the behavior of my 
system is exactly as you describe.

I just had a look at the code, and I found this:

     return 0 if $AutoUpdateASSP == 1;
     mlog(0,"Info: saving current script '$assp' to 
'assp_$version$modversion.pl'") if $MaintenanceLog;
     if (! copy("$assp","$base/download/assp_$version$modversion.pl")) {
         mlog(0,"warning: autoupdate: unable to save current script 
'$assp' to '$base/download/assp_$version$modversion.pl' - skip update - 
$!");
         return 0;
     }

So if it's set to only download but not install the updates 
($AutoUpdateASSP ==1) then it will NOT copy to a versioned file, 
because of that first line. Thomas, is there a reason for this?





------------------------------------------------------------------------------
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Assp-test mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/assp-test




DISCLAIMER:
*******************************************************
This email and any files transmitted with it may be confidential, legally 
privileged and protected in law and are intended solely for the use of the 

individual to whom it is addressed.
This email was multiple times scanned for viruses. There should be no 
known virus in this email!
*******************************************************


------------------------------------------------------------------------------
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Assp-test mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/assp-test

Reply via email to