----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3003/#review10253 -----------------------------------------------------------
/branches/12/res/res_stasis_snoop.c <https://reviewboard.asterisk.org/r/3003/#comment19601> I'm not sure this needs to be dynamically expanded. Unique ids of channels have a well defined upper bound, AST_MAX_UNIQUEID defined in channel.h. You could just as well make this a char array and save yourself the trouble. /branches/12/res/res_stasis_snoop.c <https://reviewboard.asterisk.org/r/3003/#comment19602> Going out on a limb here, but if this ever occurs, something has gone horribly wrong. We should never masquerade a Snoop channel: that means someone has performed an ast_channel_yank and is now doing something godawful. It may be worthwhile having an assert in here, or something that indicates that this should not have occurred - even if we do try to 'handle it gracefully'. - Matt Jordan On Nov. 12, 2013, 6:43 p.m., Joshua Colp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3003/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2013, 6:43 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-22780 > https://issues.asterisk.org/jira/browse/ASTERISK-22780 > > > Repository: Asterisk > > > Description > ------- > > This patch adds a snoop operation to channels which allows spying and > whispering to occur. The operation creates a Snoop channel, sends it into a > provided Stasis application, and returns a snapshot of it. Once in the Stasis > application any normal operation can be done with it (such as recording or > placing into a bridge). > > > Diffs > ----- > > /branches/12/rest-api/api-docs/channels.json 402707 > /branches/12/res/res_stasis_snoop.exports.in PRE-CREATION > /branches/12/res/res_stasis_snoop.c PRE-CREATION > /branches/12/res/res_ari_channels.c 402707 > /branches/12/res/ari/resource_channels.c 402707 > /branches/12/res/ari/resource_channels.h 402707 > /branches/12/main/audiohook.c 402707 > /branches/12/include/asterisk/stasis_app_snoop.h PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/3003/diff/ > > > Testing > ------- > > Used my softphone to call in and then swagger-ui to create snoop channels to > do various things. Testsuite test coming soon! > > > Thanks, > > Joshua Colp > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
