> On Dec. 18, 2013, 2:28 a.m., Matt Jordan wrote: > > /branches/12/channels/chan_sip.c, line 30853 > > <https://reviewboard.asterisk.org/r/3072/diff/1/?file=49615#file49615line30853> > > > > The length of this should be AST_MAX_EXTENSION + the length of the > > context + 2. (Alternatively, use AST_MAX_MAILBOX_UNIQUEID) > > > > app_voicemail uses AST_MAX_EXTENSION as the maximum mailbox name > > length, which is 80 characters. Theoretically this could chop the name of > > the mailbox down from what is supported in app_voicemail. > > > > Since we haven't defined the length supported by ARI, we might as well > > go with what we know is our current max length.
Used AST_MAX_MAILBOX_UNIQUEID for this channel driver and the other channel drivers that have a fixed buffer size. > On Dec. 18, 2013, 2:28 a.m., Matt Jordan wrote: > > /branches/12/funcs/func_vmcount.c, lines 51-68 > > <https://reviewboard.asterisk.org/r/3072/diff/1/?file=49626#file49626line51> > > > > This change should be documented in CHANGES/UPGRADE as well Done. Though it doesn't really matter. The only difference is where the @default for an app_voicemail mailbox is added. If a user doesn't add the @default for an app_voicemail mailbox it will still be added by app_voicemail. - rmudgett ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3072/#review10445 ----------------------------------------------------------- On Dec. 13, 2013, 11:45 p.m., rmudgett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3072/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2013, 11:45 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > Removed code from the system for normal mailbox handling that appends > @default to the mailbox identifier if it does not have a context. The only > exception is the legacy hasvoicemail users.conf option. The legacy option > will only work for app_voicemail mailboxes. (I'd like to just remove the > hasvoicemail option since it is usually superceeded by an explicit mailbox > option. :) ) The system cannot make any assumptions about the format of the > mailbox identifer used by app_voicemail. > > chan_sip and chan_dahdi/sig_pri had the most changes because they both tried > to interpret the mailbox identifier. chan_sip just stored and compared the > two components. chan_dahdi actually used the box information. > > The ISDN MWI support configuration options had to be reworked because > chan_dahdi was parsing the box@context format to get the box number. As a > result the mwi_vm_boxes chan_dahdi.conf option was added and is documented in > the chan_dahdi.conf.sample file. > > > Diffs > ----- > > /branches/12/res/res_xmpp.c 403807 > /branches/12/res/res_jabber.c 403807 > /branches/12/main/app.c 403807 > /branches/12/include/asterisk/app.h 403807 > /branches/12/funcs/func_vmcount.c 403807 > /branches/12/configs/voicemail.conf.sample 403807 > /branches/12/configs/skinny.conf.sample 403807 > /branches/12/configs/sip.conf.sample 403807 > /branches/12/configs/iax.conf.sample 403807 > /branches/12/configs/chan_dahdi.conf.sample 403807 > /branches/12/channels/sip/include/sip.h 403807 > /branches/12/channels/sig_pri.c 403807 > /branches/12/channels/sig_pri.h 403807 > /branches/12/channels/chan_unistim.c 403807 > /branches/12/channels/chan_skinny.c 403807 > /branches/12/channels/chan_sip.c 403807 > /branches/12/channels/chan_mgcp.c 403807 > /branches/12/channels/chan_iax2.c 403807 > /branches/12/channels/chan_h323.c 403807 > /branches/12/channels/chan_dahdi.c 403807 > /branches/12/apps/app_voicemail.c 403807 > /branches/12/UPGRADE.txt 403807 > /branches/12/CHANGES 403807 > > Diff: https://reviewboard.asterisk.org/r/3072/diff/ > > > Testing > ------- > > Tested chan_dahdi to be sure that the new mwi_vm_boxes option parses > correctly and sets up mailboxes. > Tested chan_sip to be sure that the mailbox option works. > > > Thanks, > > rmudgett > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev