----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3072/ -----------------------------------------------------------
(Updated Dec. 19, 2013, 4:57 p.m.) Status ------ This change has been marked as submitted. Review request for Asterisk Developers. Repository: Asterisk Description ------- Removed code from the system for normal mailbox handling that appends @default to the mailbox identifier if it does not have a context. The only exception is the legacy hasvoicemail users.conf option. The legacy option will only work for app_voicemail mailboxes. (I'd like to just remove the hasvoicemail option since it is usually superceeded by an explicit mailbox option. :) ) The system cannot make any assumptions about the format of the mailbox identifer used by app_voicemail. chan_sip and chan_dahdi/sig_pri had the most changes because they both tried to interpret the mailbox identifier. chan_sip just stored and compared the two components. chan_dahdi actually used the box information. The ISDN MWI support configuration options had to be reworked because chan_dahdi was parsing the box@context format to get the box number. As a result the mwi_vm_boxes chan_dahdi.conf option was added and is documented in the chan_dahdi.conf.sample file. Diffs ----- /branches/12/res/res_xmpp.c 404264 /branches/12/res/res_jabber.c 404264 /branches/12/main/app.c 404264 /branches/12/include/asterisk/app.h 404264 /branches/12/funcs/func_vmcount.c 404264 /branches/12/configs/voicemail.conf.sample 404264 /branches/12/configs/skinny.conf.sample 404264 /branches/12/configs/sip.conf.sample 404264 /branches/12/configs/iax.conf.sample 404264 /branches/12/configs/chan_dahdi.conf.sample 404264 /branches/12/channels/sip/include/sip.h 404264 /branches/12/channels/sig_pri.c 404264 /branches/12/channels/sig_pri.h 404264 /branches/12/channels/h323/chan_h323.h 404264 /branches/12/channels/chan_unistim.c 404264 /branches/12/channels/chan_skinny.c 404264 /branches/12/channels/chan_sip.c 404264 /branches/12/channels/chan_mgcp.c 404264 /branches/12/channels/chan_iax2.c 404264 /branches/12/channels/chan_h323.c 404264 /branches/12/channels/chan_dahdi.c 404264 /branches/12/channels/chan_dahdi.h 404264 /branches/12/apps/app_voicemail.c 404264 /branches/12/UPGRADE.txt 404264 /branches/12/CHANGES 404264 Diff: https://reviewboard.asterisk.org/r/3072/diff/ Testing ------- Tested chan_dahdi to be sure that the new mwi_vm_boxes option parses correctly and sets up mailboxes. Tested chan_sip to be sure that the mailbox option works. Thanks, rmudgett
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev