----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3093/#review10500 -----------------------------------------------------------
/branches/12/include/asterisk/res_pjsip_exten_state.h <https://reviewboard.asterisk.org/r/3093/#comment19957> In the UPGRADE notes, we'll need to note that the ABI for this module will have changed (which is unfortunate, but necessary). This module, and any other that use it, will have to be updated. /branches/12/res/res_pjsip_dialog_info.c <https://reviewboard.asterisk.org/r/3093/#comment19959> pj_xml_print returns -1, not 0, if the body is too large. You should check for size < 0. /branches/12/res/res_pjsip_dialog_info.c <https://reviewboard.asterisk.org/r/3093/#comment19958> If size == ast_str_size(*body_text), then this will insert a '\0' into the last character of the string, potentially blowing away the '>' or some other character in the XML body. You should pass ast_str_size(*body_text) - 1 as the max size to pj_xml_print to leave yourself room for the NULL character. We're going to need some tests :-) - Matt Jordan On Dec. 24, 2013, 8:53 p.m., Joshua Colp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3093/ > ----------------------------------------------------------- > > (Updated Dec. 24, 2013, 8:53 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-21443 > https://issues.asterisk.org/jira/browse/ASTERISK-21443 > > > Repository: Asterisk > > > Description > ------- > > Some devices use the dialog-info+xml to get presence information about an > extension. The attached change implements this but DOES NOT implement the > "pickup ringing channel" functionality available on Snoms. > > To facilitate this implementation I have also changed it so the subscription > is passed to the body creation callback. This allows implementations to store > state information on the subscription. > > > Diffs > ----- > > /branches/12/res/res_pjsip_pidf.c 404578 > /branches/12/res/res_pjsip_exten_state.c 404578 > /branches/12/res/res_pjsip_dialog_info.c PRE-CREATION > /branches/12/include/asterisk/res_pjsip_exten_state.h 404578 > > Diff: https://reviewboard.asterisk.org/r/3093/diff/ > > > Testing > ------- > > Subscribed to an extension from a device that uses dialog-info+xml. Confirmed > NOTIFY messages going out contain the expected content. > > > Thanks, > > Joshua Colp > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
