----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3093/#review10544 -----------------------------------------------------------
/branches/12/res/res_pjsip_dialog_info.c <https://reviewboard.asterisk.org/r/3093/#comment19996> "dialog-info+xml" seems to get used quite a bit in this file. Put this in a #define or a static variable. - opticron On Jan. 3, 2014, 2:18 p.m., Joshua Colp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3093/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2014, 2:18 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-21443 > https://issues.asterisk.org/jira/browse/ASTERISK-21443 > > > Repository: Asterisk > > > Description > ------- > > Some devices use the dialog-info+xml to get presence information about an > extension. The attached change implements this but DOES NOT implement the > "pickup ringing channel" functionality available on Snoms. > > To facilitate this implementation I have also changed it so the subscription > is passed to the body creation callback. This allows implementations to store > state information on the subscription. > > > Diffs > ----- > > /branches/12/res/res_pjsip_pidf.c 404831 > /branches/12/res/res_pjsip_exten_state.c 404831 > /branches/12/res/res_pjsip_dialog_info.c PRE-CREATION > /branches/12/include/asterisk/res_pjsip_exten_state.h 404831 > /branches/12/UPGRADE.txt 404831 > > Diff: https://reviewboard.asterisk.org/r/3093/diff/ > > > Testing > ------- > > Subscribed to an extension from a device that uses dialog-info+xml. Confirmed > NOTIFY messages going out contain the expected content. > > > Thanks, > > Joshua Colp > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
