-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3356/
-----------------------------------------------------------
(Updated March 17, 2014, 8:12 p.m.)
Review request for Asterisk Developers.
Bugs: asterisk-23488
https://issues.asterisk.org/jira/browse/asterisk-23488
Repository: Asterisk
Description
-------
Callerid checksum-ing is being handled incorrectly here. When the checksum is
calculated to be 0x00, it will perform 0x100-0x00 which results in 0x100. This
value will then fail the otherwise correct callerid message. It was intended
for devices on the rx side to simply add the calculated checksum to the
transmitted 2's compliment checksum. A much simpler operation.
Diffs
-----
/branches/1.8/main/callerid.c 410575
Diff: https://reviewboard.asterisk.org/r/3356/diff/
Testing (updated)
-------
v2 patch is now allowing production tests to pass 100%
Thanks,
rmeyerriecks
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
