> On March 18, 2014, 12:43 p.m., wdoekes wrote: > > /branches/12/res/res_pjsip/config_system.c, lines 200-206 > > <https://reviewboard.asterisk.org/r/3343/diff/2/?file=56168#file56168line200> > > > > No ao2_ref(discovered_nameservers, -1); here?
Fixed in SVN, cheers! - Joshua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3343/#review11269 ----------------------------------------------------------- On March 17, 2014, 10:53 p.m., Joshua Colp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3343/ > ----------------------------------------------------------- > > (Updated March 17, 2014, 10:53 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23435 > https://issues.asterisk.org/jira/browse/ASTERISK-23435 > > > Repository: Asterisk > > > Description > ------- > > This change adds a configuration option for setting nameservers to be used by > the PJSIP DNS client. If this option is not set then the system nameservers > are retrieved and used instead. > > This also allows the nameservers to be changed by doing a reload. > > In case others are wondering as Olle was: > > PJLIB-Util (part of pjproject) provides a DNS client which can optionally > (but is highly suggested) to be used with PJSIP. It provides asynchronous > DNS, SRV lookups, multiple record support, etc. Right now this isn't enabled > so we are simply doing A/AAAA record lookups. The reason it's not enabled is > that explicit nameservers *must* be provided to it when enabling it. It will > not use the system ones by itself. The change up on reviewboard enables it by > default using the system nameservers it finds, but with the ability to > override or completely disable it if a user wants. The reason I also provide > reload functionality is that people in #asterisk-dev expressed a concern that > users may change nameservers but don't want to restart Asterisk, which is > understandable. > > > Diffs > ----- > > /branches/12/res/res_pjsip/include/res_pjsip_private.h 410470 > /branches/12/res/res_pjsip/config_system.c 410470 > /branches/12/res/res_pjsip/config_global.c 410470 > /branches/12/res/res_pjsip.c 410470 > /branches/12/main/dns.c 410470 > /branches/12/include/asterisk/dns.h 410470 > /branches/12/CHANGES 410470 > > Diff: https://reviewboard.asterisk.org/r/3343/diff/ > > > Testing > ------- > > Explicitly set nameservers and confirmed they were used by PJSIP. Disabled it > and confirmed that the DNS client was disabled. Set to auto (explicitly and > by default) and confirmed that the system nameservers were used. > > > Thanks, > > Joshua Colp > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
