----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3313/#review11474 -----------------------------------------------------------
Ship it! Ship It! ./asterisk/trunk/lib/python/asterisk/pluggable_modules.py <https://reviewboard.asterisk.org/r/3313/#comment21177> Minor nitpick: The log entry saying the file is moved will occur prior to this log entry saying the local file was created. Recommend moving this debug log entry to prior to move_file(). - Scott Griepentrog On April 2, 2014, 11:23 a.m., Scott Emidy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3313/ > ----------------------------------------------------------- > > (Updated April 2, 2014, 11:23 a.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23217 > https://issues.asterisk.org/jira/browse/ASTERISK-23217 > > > Repository: testsuite > > > Description > ------- > > This test uses the Pluggable Module Framework in order to convert a YAML > configuration into an executable Call File by putting it into the correct > directory, which is the 'astspooldir' directory. > > > Diffs > ----- > > ./asterisk/trunk/tests/pbx/tests.yaml 4726 > ./asterisk/trunk/tests/pbx/create_call_files/test-config.yaml PRE-CREATION > ./asterisk/trunk/tests/pbx/create_call_files/configs/ast1/extensions.conf > PRE-CREATION > ./asterisk/trunk/sample-yaml/callfiles-config.yaml.sample PRE-CREATION > ./asterisk/trunk/lib/python/asterisk/pluggable_modules.py 4726 > > Diff: https://reviewboard.asterisk.org/r/3313/diff/ > > > Testing > ------- > > > Thanks, > > Scott Emidy > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev