----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3313/#review11517 -----------------------------------------------------------
My review was for dependencies only to avoid failures caused by modules I don't build. Others have already said "Ship It!" so once dependencies are fixed please don't wait on my approval. ./asterisk/trunk/tests/pbx/create_call_files/test-config.yaml <https://reviewboard.asterisk.org/r/3313/#comment21248> Please add pbx_spool to dependencies. Also does this actually require 11.8.0, or did you mean to require 1.8.0? - Corey Farrell On April 2, 2014, 1:38 p.m., Scott Emidy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3313/ > ----------------------------------------------------------- > > (Updated April 2, 2014, 1:38 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23217 > https://issues.asterisk.org/jira/browse/ASTERISK-23217 > > > Repository: testsuite > > > Description > ------- > > This test uses the Pluggable Module Framework in order to convert a YAML > configuration into an executable Call File by putting it into the correct > directory, which is the 'astspooldir' directory. > > > Diffs > ----- > > ./asterisk/trunk/tests/pbx/tests.yaml 4726 > ./asterisk/trunk/tests/pbx/create_call_files/test-config.yaml PRE-CREATION > ./asterisk/trunk/tests/pbx/create_call_files/configs/ast1/extensions.conf > PRE-CREATION > ./asterisk/trunk/sample-yaml/callfiles-config.yaml.sample PRE-CREATION > ./asterisk/trunk/lib/python/asterisk/pluggable_modules.py 4726 > > Diff: https://reviewboard.asterisk.org/r/3313/diff/ > > > Testing > ------- > > > Thanks, > > Scott Emidy > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
