----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3496/#review12419 -----------------------------------------------------------
/asterisk/trunk/lib/python/asterisk/asterisk.py <https://reviewboard.asterisk.org/r/3496/#comment22670> Might want to remove trailing whitespace while you are in there. /asterisk/trunk/lib/python/asterisk/test_case.py <https://reviewboard.asterisk.org/r/3496/#comment22668> This should be kept in vim config files and not in the source code itself. /asterisk/trunk/lib/python/asterisk/test_config.py <https://reviewboard.asterisk.org/r/3496/#comment22667> This should be kept in vim config files and not in the source code itself. /asterisk/trunk/lib/python/asterisk/valgrind.py <https://reviewboard.asterisk.org/r/3496/#comment22662> I would take out commented out code. /asterisk/trunk/lib/python/asterisk/valgrind.py <https://reviewboard.asterisk.org/r/3496/#comment22666> Why use string concatenation here and interpolation throughout most of the rest of the file? /asterisk/trunk/lib/python/asterisk/valgrind.py <https://reviewboard.asterisk.org/r/3496/#comment22660> Since ast_dir is not used again, you could just build the path to the xml file in one line. Also, wouldn't this result in ast_dir//valgrind.xml currently? /asterisk/trunk/lib/python/asterisk/valgrind.py <https://reviewboard.asterisk.org/r/3496/#comment22672> This should be kept in vim config files and not in the source code itself. /asterisk/trunk/runtests.py <https://reviewboard.asterisk.org/r/3496/#comment22671> This should be kept in vim config files and not in the source code itself. - Samuel Galarneau On June 6, 2014, 2:06 p.m., Scott Griepentrog wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3496/ > ----------------------------------------------------------- > > (Updated June 6, 2014, 2:06 p.m.) > > > Review request for Asterisk Developers. > > > Repository: testsuite > > > Description > ------- > > This patch adds support for running Asterisk under Valgrind (said > "Val-Grinned") to check for memory allocation and reference problems. > > To use, add -V to ./runtests.py and get a cup of coffee. Any errors will be > displayed in a stack trace format. > > Tests can also activate valgrind in the yaml configuration. > > By default, only confirmed leaks will be shown - thoses where all copies of > the pointer to the allocation have been released. Additional leak checking > can be enabled. > > > Diffs > ----- > > /asterisk/trunk/runtests.py 5100 > /asterisk/trunk/lib/python/asterisk/valgrind.py PRE-CREATION > /asterisk/trunk/lib/python/asterisk/test_config.py 5100 > /asterisk/trunk/lib/python/asterisk/test_case.py 5100 > /asterisk/trunk/lib/python/asterisk/asterisk.py 5100 > /asterisk/trunk/configs/valgrind.supp PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/3496/diff/ > > > Testing > ------- > > Used to locate reference problems on Userevent issue, and incorporated > several improvements over the prior attempt. > > > Thanks, > > Scott Griepentrog > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
