George Joseph wrote:

<snip>



How about we use the pattern approach but compile in patterns for trunk
and user.  There are lots of minor differences between ITSPs and phones
and I just worry that in the quest to create something for everyone we
create something that's useful to no one.

If it does not impact any of the existing code and is easy for a user, then sure. That being said... get feedback any way you can before doing anything. This is a complicated area.



    Given the following (even without documentation) could someone
    coming from sip.conf understand it?

    [1000]
    type=phone
    secret=notverysecret
    context=trusted
    disallow=all
    allow=g722
    mailbox=1000

    I err on the side of yes. That's what I think is needed. Heck, it's
    hard enough to get people to realize they can use templates.

I love templates so much that I enhanced manager and config so you read
and write templates via AMI GetConfig and UpdateConfig.

If we compile in basic patterns it could be as simple as

[1000]
type = composite                 ; ok, maybe composite and pattern
aren't good names.
pattern = phone                  ; built-in pattern
incoming_password = notverysecret
context = trusted
disallow = all
allow = g722
mailboxes = 1000


Are you OK with a separate config file?  It would make manipulating it
easier since there'd be no duplicate section names.

Yes.

--
Joshua Colp
Digium, Inc. | Senior Software Developer
445 Jan Davis Drive NW - Huntsville, AL 35806 - US
Check us out at: www.digium.com & www.asterisk.org

--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
  http://lists.digium.com/mailman/listinfo/asterisk-dev

Reply via email to