----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4090/#review13791 -----------------------------------------------------------
Ship it! Please discard my findings, they are minor. I'd like to see this committed ASAP so further improvements can be made against it. - Corey Farrell On Oct. 16, 2014, 5:23 p.m., Scott Griepentrog wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4090/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2014, 5:23 p.m.) > > > Review request for Asterisk Developers. > > > Repository: testsuite > > > Description > ------- > > This adds very basic valgrind support, which is convenient for manual test > runs but does not (yet) include support for more automated valgrind usage. > > 1) CLI flag '-V' enables valgrind (./runtests -V -t tests/test) > > 2) Minimal changes to testsuite, other improvements can be added later if > desired > > 3) Valgrind output is picked up by error logging and shown after test run. > > 4) Unlike previous valgrind attempt, this one works fine on tests with > multiple asterisk instances > > > Diffs > ----- > > /asterisk/trunk/runtests.py 5733 > /asterisk/trunk/lib/python/asterisk/test_case.py 5733 > /asterisk/trunk/lib/python/asterisk/asterisk.py 5733 > > Diff: https://reviewboard.asterisk.org/r/4090/diff/ > > > Testing > ------- > > > Thanks, > > Scott Griepentrog > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
