> On Oct. 16, 2014, 5:58 p.m., Kevin Harwell wrote: > > /asterisk/trunk/runtests.py, lines 461-462 > > <https://reviewboard.asterisk.org/r/4090/diff/1/?file=68379#file68379line461> > > > > Not a huge fan of using an environment variable for this (could > > probably be convinced otherwise though). Maybe pass in as a param?
While I concur with your distaste for using an environment variable like this, it has several advantages: 1) transparently gets passed to lib/python/asterisk/asterisk.py even if a custom run-test python application is being used (doesn't require rewriting existing tests) 2) tests written in other langauges can test for the flag (although I don't see a need for this happening) 3) It is possible to set the environment variable before calling ./runtests.py to trigger valgrind usage (although this will be more useful later when automated failure detection is added). - Scott ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4090/#review13561 ----------------------------------------------------------- On Oct. 16, 2014, 4:23 p.m., Scott Griepentrog wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4090/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2014, 4:23 p.m.) > > > Review request for Asterisk Developers. > > > Repository: testsuite > > > Description > ------- > > This adds very basic valgrind support, which is convenient for manual test > runs but does not (yet) include support for more automated valgrind usage. > > 1) CLI flag '-V' enables valgrind (./runtests -V -t tests/test) > > 2) Minimal changes to testsuite, other improvements can be added later if > desired > > 3) Valgrind output is picked up by error logging and shown after test run. > > 4) Unlike previous valgrind attempt, this one works fine on tests with > multiple asterisk instances > > > Diffs > ----- > > /asterisk/trunk/runtests.py 5733 > /asterisk/trunk/lib/python/asterisk/test_case.py 5733 > /asterisk/trunk/lib/python/asterisk/asterisk.py 5733 > > Diff: https://reviewboard.asterisk.org/r/4090/diff/ > > > Testing > ------- > > > Thanks, > > Scott Griepentrog > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
