----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4050/#review13858 -----------------------------------------------------------
/trunk/main/channel.c <https://reviewboard.asterisk.org/r/4050/#comment24338> Nothing you did in channel.c appears to require this inclusion. /trunk/main/pbx.c <https://reviewboard.asterisk.org/r/4050/#comment24337> Consider an assertion here? This could probably use a unit test, especially since you didn't add any support for this feature to any of the existing channel drivers in this patch. I would imagine a unit test to do the following: 1 - Create a channel tech with a presence_provider function (see res/parking/parking_tests for an example of a temporary tech just used for a unit test) 2 - Create a channel using that tech 3 - Use your presence provider function to retrieve the presence state of the channel 4 - Change the presence state of the channel 5 - Check presence state again 6 - release the channel - Jonathan Rose On Oct. 16, 2014, 11:26 p.m., gareth wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4050/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2014, 11:26 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24363 > https://issues.asterisk.org/jira/browse/ASTERISK-24363 > > > Repository: Asterisk > > > Description > ------- > > This patch adds the ability for channel drivers to supply presence > information in a similar manner to device state. > > eg: exten => XXX,hint,,<Technology>/<Resource> > > > Diffs > ----- > > /trunk/main/presencestate.c 425756 > /trunk/main/pbx.c 425756 > /trunk/main/channel.c 425756 > /trunk/include/asterisk/channel.h 425756 > > Diff: https://reviewboard.asterisk.org/r/4050/diff/ > > > Testing > ------- > > Code is originally written as part of ASTERISK-13145 which has undergone > extensive testing. > > > Thanks, > > gareth > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev