> On Dec. 1, 2014, 11:46 p.m., Jonathan Rose wrote: > > /trunk/main/pbx.c, lines 11874-11877 > > <https://reviewboard.asterisk.org/r/4050/diff/2/?file=68397#file68397line11874> > > > > Consider an assertion here?
That part of the code (and it's comment) were copied from device_state_cb(). The NULL check may be unnecessary now as modification to hintdevices is protected by context_merge_lock, so device->hint can't be set to NULL by hintdevice_destroy during a dialplan reload. I could remove the check from both callbacks if required. - gareth ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4050/#review13858 ----------------------------------------------------------- On Dec. 3, 2014, 4:32 a.m., gareth wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4050/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2014, 4:32 a.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24363 > https://issues.asterisk.org/jira/browse/ASTERISK-24363 > > > Repository: Asterisk > > > Description > ------- > > This patch adds the ability for channel drivers to supply presence > information in a similar manner to device state. > > eg: exten => XXX,hint,,<Technology>/<Resource> > > > Diffs > ----- > > /trunk/main/presencestate.c 428167 > /trunk/main/pbx.c 428167 > /trunk/main/channel.c 428167 > /trunk/include/asterisk/channel.h 428167 > > Diff: https://reviewboard.asterisk.org/r/4050/diff/ > > > Testing > ------- > > Code is originally written as part of ASTERISK-13145 which has undergone > extensive testing. > > > Thanks, > > gareth > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
