-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4412/
-----------------------------------------------------------

Review request for Asterisk Developers.


Bugs: ASTERISK-24701
    https://issues.asterisk.org/jira/browse/ASTERISK-24701


Repository: Asterisk


Description
-------

When writing to a websocket if a timeout occurred the underlying socket did not 
get closed/disconnected. This patch makes sure the websocket gets disconnected 
on a write timeout. Also a notice is logged stating that the websocket was 
disconnected.


Diffs
-----

  branches/13/res/res_http_websocket.c 431641 
  branches/13/res/ari/ari_websockets.c 431641 

Diff: https://reviewboard.asterisk.org/r/4412/diff/


Testing
-------

I had trouble getting an actual write timeout to occur, so I just forced an 
error on write to make sure the underlying socket would get closed and the 
notice was logged. Also ran relevant testsuite and unit tests.


Thanks,

Kevin Harwell

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Reply via email to