On 2019-09-21 19:35, Kalle Valo wrote:
The commit log tells nothing about fast, it should always document the
design decisions. Why this fast dump, what's the benefit? Why not
always
use the fast dump and forget the slow dump (or vice versa)? There needs
to be really good reasons to have all this complexity to support both
slow and fast dumps.
fastdump is new added in fimrware of sdio, so if it is use old firmeare,
then it will
not support fastdump, then it need to use slow dump type.
it is to compatibility for old/new version firmware.
+ ath10k_err(ar, "check fw reg : %x\n", param);
+}
This is a debug message, not an error. And debug messages should use
format "sdio hi_option_flag2 %x\n".
