On Tue, Jun 02, 2009 at 04:31:40PM -0400, Bob Copeland wrote:
> On Tue, Jun 2, 2009 at 4:19 PM, Mark Hindley <m...@hindley.org.uk> wrote:
> >
> > No, they look very similar, except mine is against 2.6.29, so I haven't
> > used sw_scan_{start,complete}
>
> Yeah, they are practically the same. One good (or bad) thing
> about the sw_scan callback is it will go into scan mode even
> while you are associated (e.g. background scanning). I don't
> know how that looks since I don't have any applicable hw. If
> you have any suggestions on that front or blink pattern to use,
> etc, please feel free to shout.
OK, I have just tried this with 2.6.30. It works fine, but, as you
suspected, it seems a little odd to have the leds suggest the card has
disassociated each time there is a scan.
This patch fixes that for me.
I know HW leds has been a much requested item and would suggest this is
pushed into testing soon.
Mark
diff --git a/drivers/net/wireless/ath5k/base.c
b/drivers/net/wireless/ath5k/base.c
index b4ed322..4043213 100644
--- a/drivers/net/wireless/ath5k/base.c
+++ b/drivers/net/wireless/ath5k/base.c
@@ -3082,7 +3082,8 @@ static void ath5k_bss_info_changed(struct ieee80211_hw
*hw,
static void ath5k_sw_scan_start(struct ieee80211_hw *hw)
{
struct ath5k_softc *sc = hw->priv;
- ath5k_hw_set_ledstate(sc->ah, AR5K_LED_SCAN);
+ if (!sc->assoc)
+ ath5k_hw_set_ledstate(sc->ah, AR5K_LED_SCAN);
}
static void ath5k_sw_scan_complete(struct ieee80211_hw *hw)
_______________________________________________
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel
