On 2 November 2011 10:52, Felix Fietkau <n...@openwrt.org> wrote:
>> I don't know the exact electronic details of the implementation, so I'd go
>> with
>> a list of known-to-be-good values (passed to the driver via platform-data)
>> instead of a causal check (e.g. don't allow to set the TX and RX to the same
>> antenna or whatever you imagine to possibly be an invalid setting).
> I think passing such 'magic' values from user space to the driver is a
> bad idea. The abstraction should happen within the driver and exposed
> via the antenna control API.
+1. I'll see if we can document what those bits are, but yes, please
pass them in via platform_data in the board setup code (ie, all
in-kernel) and then let the user select from a list of valid ones.
+1 if you add a user-parsable tag and description to the list of values, eg:
{ 0x1, "vert", "vertical RX" },
{ 0x2, "horiz", "horizontal RX" },
{ -1, NULL, NULL}
Adrian
_______________________________________________
ath9k-devel mailing list
ath9k-devel@lists.ath9k.org
https://lists.ath9k.org/mailman/listinfo/ath9k-devel
