On 2013-03-11 11:00 PM, Ben Greear wrote: > On 03/11/2013 02:51 PM, Felix Fietkau wrote: >> On 2013-03-11 10:44 PM, Ben Greear wrote: >>> On 03/11/2013 02:36 PM, Felix Fietkau wrote: >>>> On 2013-03-11 10:01 PM, Ben Greear wrote: >>>>> On 03/11/2013 01:17 PM, Felix Fietkau wrote: >>> >>>>> I am not sure what you are suggesting. I enabled this override >>>>> only when ONUS is selected because I wanted it clear that users >>>>> were taking their regulatory compliance into their own hands. >>>> And as far as I understand, CONFIG_CFG80211_CERTIFICATION_ONUS already >>>> enables some code in cfg80211 that allows a special type of regulatory >>>> change request from user space that bypasses intersection. >>>> >>>>> I always want the module option at least visible so that >>>>> you don't have to muck with modprobe.conf just to get ath9k.ko >>>>> to load when it's compiled differently. >>>>> >>>>> For the second part, you want the ability to set the regdomain >>>>> be a compile-time option like CONFIG_ATH9K_OVERRIDE_REGDOMAIN >>>>> or something like that? >>>> Something like that, yes. It should depend on >>>> CONFIG_CFG80211_CERTIFICATION_ONUS and should contain a help text that >>>> strongly discourages any distribution from enabling it in their kernel >>>> builds. >>> >>> It seems to me that this doesn't gain much. The ONUS configuration is >>> already >>> strongly discouraged from vendor kernels. If you are already compiling >>> with ONUS set, is there any reason you'd care to disable the override >>> module option? When you don't set the module option, nothing happens >>> anyway... >> I'd like to avoid accumulating more hackish driver specific module >> options for working around a generic issue. > > I don't think I'm up for any significant re-write of the > regdomain logic, and I'm not sure it's worth the effort > of anyone doing this for code that will be compiled out > of all vendor kernels anyway... Who said anything about rewriting the regdomain logic? The code is already there. If you make it a compile time option that gets rid of the code in ath_regd_init_wiphy, it doesn't need a module parameter - iw reg set will do the job, and the default still comes from EEPROM.
- Felix _______________________________________________ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
